[GitHub] [lucene] romseygeek commented on a change in pull request #668: LUCENE-10414: Add fn:fuzzyTerm interval function to flexible query parser

[GitBox <gi...@apache.org>]

romseygeek commented on a change in pull request #668:
URL: https://github.com/apache/lucene/pull/668#discussion_r802751153



##########
File path: lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/nodes/intervalfn/FuzzyTerm.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.queryparser.flexible.standard.nodes.intervalfn;
+
+import java.util.Locale;
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.index.Term;
+import org.apache.lucene.queries.intervals.Intervals;
+import org.apache.lucene.queries.intervals.IntervalsSource;
+import org.apache.lucene.search.FuzzyQuery;
+
+/**
+ * An interval function equivalent to {@link FuzzyQuery}. A fuzzy term expands to a disjunction of
+ * intervals of terms that are within the specified {@code maxEdits} from the provided term. A limit
+ * of {@code maxExpansions} prevents the internal implementation from blowing up on too many
+ * potential candidate terms.
+ */
+public class FuzzyTerm extends IntervalFunction {
+  private final String term;
+  private final int maxEdits;
+  private final Integer maxExpansions;
+
+  public FuzzyTerm(String term, Integer maxEdits, Integer maxExpansions) {
+    this.term = term;
+    this.maxEdits = maxEdits == null ? FuzzyQuery.defaultMaxEdits : maxEdits;
+    this.maxExpansions = maxExpansions == null ? Intervals.DEFAULT_MAX_EXPANSIONS : maxExpansions;
+  }
+
+  @Override
+  public IntervalsSource toIntervalSource(String field, Analyzer analyzer) {
+    var fuzzyQuery = new FuzzyQuery(new Term(field, term), maxEdits);

Review comment:
       Yep we do this all over the place in ES as well.  Maybe we should just make FuzzyAutomatonBuilder public?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org