You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Florentino Sainz (Code Review)" <ge...@cloudera.org> on 2019/03/17 20:43:00 UTC
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
Florentino Sainz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12773
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
......................................................................
This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting it in JavaAssist) and also the table which is being read (so users know what the Scanner is actually Scanning)
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/1
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 1
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#5).
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
......................................................................
This toString is shown in Spark UI SQL view,
right now what users see in the Spark UI is just the object
default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name
(I've tested using Javaassist code-injection in my cloudera cluster,
as I don't have the tools to build this library and I can't upgrade
the library there anyways)
and also the table which is being read
(so users know what the Scanner is actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" ) instead allowing
much easier profiling on complex queries/DFs. So users can see that its
a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/5
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 5
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 8
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 17:58:08 +0000
Gerrit-HasComments: No
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#8).
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
This toString is shown in Spark UI SQL view, right now what users see
in the Spark UI is just the object default toString
("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name and also the table
which is being read (so users know what we are actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" )
instead, allowing much easier profiling on complex queries/DFs.
So users can see that its a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/8
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 8
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#6).
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
......................................................................
This toString is shown in Spark UI SQL view,
right now what users see in the Spark UI is just the object
default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name
(I've tested using Javaassist code-injection in my cloudera cluster,
as I don't have the tools to build this library and I can't upgrade
the library there anyways)
and also the table which is being read
(so users know what the Scanner is actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" )
instead, allowing
much easier profiling on complex queries/DFs. So users can see that its
a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/6
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 6
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#3).
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
......................................................................
This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting it in JavaAssist) and also the table which is being read (so users know what the Scanner is actually Scanning)
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/3
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 3
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#4).
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
......................................................................
This toString is shown in Spark UI SQL view,
right now what users see in the Spark UI is just the object
default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name
(right now I'm injecting it in JavaAssist)
and also the table which is being read
(so users know what the Scanner is actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" ) instead allowing
much easier profiling on complex queries/DFs. So users can see that its
a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/4
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 4
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 8
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 17:59:43 +0000
Gerrit-HasComments: No
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#2).
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
......................................................................
This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting it in JavaAssist) and also the table which is being read (so users know what the Scanner is actually Scanning)
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/2
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 2
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString ("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a") which doesn't provide good information.
......................................................................
Patch Set 6:
(4 comments)
Thanks for the patch. It looks good; I left a few comments about style and formatting.
http://gerrit.cloudera.org:8080/#/c/12773/6//COMMIT_MSG
Commit Message:
PS6:
Please reformat your commit message as per the guidelines here: https://chris.beams.io/posts/git-commit
There's already good content here, so I'd focus on:
1. a one-line summary of the issue first
2. proper wrapping of the long lines
You may also want to check your line endings; it's not clear whether they're LF (maybe they're CRLF and you're writing from a Windows machine?). https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types has more information.
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@427
PS6, Line 427:
You have some extra whitespace here (which gerrit flagged); could you remove it and resubmit your patch?
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@428
PS6, Line 428: /**
Since this is Javadoc, could you add a @return element describing what the method returns? Search for @return in this file for some inspiration.
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@430
PS6, Line 430: * Relevant as is shown in Spark UI SQL view
I think this part of the comment can be dropped; anyone reading Java/Scala code can appreciate the usefulness of a good toString() implementation.
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 6
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 04:02:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Florentino Sainz has posted comments on this change. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: This toString is shown in Spark UI SQL view, right now what users see in the Spark UI is just the object default toString (kudurelation@8ad78a) which is non-meaningfull at all. With this change, Spark UI will show the right name (right now I'm injecting i
......................................................................
Patch Set 1:
I didn't add tests (in fact I didn't test the actual Scala code as I don't have the tools to build the project, I added this in my project using JavaAssist), feel free to include this is another more-professional commit if this one is not good enough regarding QA
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 1
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 Mar 2019 20:54:50 +0000
Gerrit-HasComments: No
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Florentino Sainz has posted comments on this change. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Patch Set 8:
(3 comments)
Fixed all the problems (I hope), I'm indeed using Windows, but git Windows client theoretically fixes any CRLF before pushing. If you referred to the "red flags" from Gerrit @ my comment, they were just spaces at the end :).
First time with Gerrit, sorry for the inconveniences, had a hard time yesterday trying to add the code during runtime for my real software (something which joins like 20 tables and I couldn't track) and didn't spend so much time with the commit.
Regards
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@427
PS6, Line 427:
> You have some extra whitespace here (which gerrit flagged); could you remov
Done
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@428
PS6, Line 428: /**
> Since this is Javadoc, could you add a @return element describing what the
Done
http://gerrit.cloudera.org:8080/#/c/12773/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@430
PS6, Line 430: * @return Kudu + tableName of the relation
> I think this part of the comment can be dropped; anyone reading Java/Scala
Done
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 8
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 15:39:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12773 )
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
This toString is shown in Spark UI SQL view, right now what users see
in the Spark UI is just the object default toString
("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name and also the table
which is being read (so users know what we are actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" )
instead, allowing much easier profiling on complex queries/DFs.
So users can see that its a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Reviewed-on: http://gerrit.cloudera.org:8080/12773
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 9
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
Posted by "Florentino Sainz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12773
to look at the new patch set (#7).
Change subject: Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
......................................................................
Add toString implementation to org.apache.kudu.spark.kudu.KuduRelation
This toString is shown in Spark UI SQL view, right now what users see
in the Spark UI is just the object default toString
("Scan org.apache.kudu.spark.kudu.KuduRelation@8ad78a")
which doesn't provide good information.
With this change, Spark UI will show the right name and also the table
which is being read (so users know what we are actually Scanning).
Spark UI SQL will now show "Scan Kudu my_table" (similar to
other sources, like Parquet/Hive, which shows "Scan Parquet my_table" )
instead, allowing much easier profiling on complex queries/DFs.
So users can see that its a KUDU source and the name of the table.
Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/12773/7
--
To view, visit http://gerrit.cloudera.org:8080/12773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58e11c36a0c7467baf43f99b9db41e2b4643bec8
Gerrit-Change-Number: 12773
Gerrit-PatchSet: 7
Gerrit-Owner: Florentino Sainz <ti...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)