You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/13 16:43:17 UTC
Re: Review Request 40731: Adding the test framework submitted by
Mandeep (@mchadha) https://reviews.apache.org/r/39056/
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 3:43 p.m.)
Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552
Repository: mesos
Description
-------
Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Diffs
-----
src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169
Diff: https://reviews.apache.org/r/40731/diff/
Testing
-------
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan
Re: Review Request 40731: Adding test fixture for checking floating
point arithmetic
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review114772
-----------------------------------------------------------
Bad patch!
Reviews applied: [40731]
Failed command: ./support/apply-review.sh -n -r 40731
Error:
2016-01-15 21:31:05 URL:https://reviews.apache.org/r/40731/diff/raw/ [7279/7279] -> "40731.patch" [1]
error: patch failed: src/tests/reservation_tests.cpp:161
error: src/tests/reservation_tests.cpp: patch does not apply
- Mesos ReviewBot
On Jan. 15, 2016, 5:44 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:44 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169
>
> Diff: https://reviews.apache.org/r/40731/diff/
>
>
> Testing
> -------
>
> Ran make check after adding Mandeep's test case to the GTEST framework.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 40731: Adding test fixture for checking floating
point arithmetic
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 5:44 p.m.)
Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
Summary (updated)
-----------------
Adding test fixture for checking floating point arithmetic
Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552
Repository: mesos
Description
-------
Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Diffs
-----
src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169
Diff: https://reviews.apache.org/r/40731/diff/
Testing
-------
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan