You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "andreahlert (via GitHub)" <gi...@apache.org> on 2026/03/24 13:38:44 UTC
Re: [PR] TUI: add full-screen interactive TUI for PR triage and review [airflow]
andreahlert commented on code in PR #63773:
URL: https://github.com/apache/airflow/pull/63773#discussion_r2981653685
##########
dev/breeze/src/airflow_breeze/utils/pr_models.py:
##########
@@ -0,0 +1,203 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Data models shared across PR triage modules."""
+
+from __future__ import annotations
+
+from concurrent.futures import Future
+from dataclasses import dataclass, field
Review Comment:
Maybe I'm missing the intent, but the dataclasses here are also defined in `pr_commands.py` with different fields (`TriageStats` 16 vs 33, `TriageContext` missing `llm_durations`/`llm_attempts`). The TUI imports from here but runtime objects come from `pr_commands`, so types won't match. Is this a WIP extraction or intentionally separate?
##########
dev/breeze/src/airflow_breeze/utils/pr_models.py:
##########
@@ -0,0 +1,203 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Data models shared across PR triage modules."""
+
+from __future__ import annotations
+
+from concurrent.futures import Future
+from dataclasses import dataclass, field
+
+# Grace period constants used by PRData and triage logic
+CHECK_FAILURE_GRACE_PERIOD_HOURS = 24
+CHECK_FAILURE_GRACE_PERIOD_WITH_ENGAGEMENT_HOURS = 96
+
+# Associations considered "collaborator" (not flagged for triage)
+COLLABORATOR_ASSOCIATIONS = {"COLLABORATOR", "MEMBER", "OWNER"}
+
+# Label / comment constants shared across modules
+READY_FOR_REVIEW_LABEL = "ready for maintainer review"
Review Comment:
These constants diverge from the ones actually used in `pr_commands.py`. `CLOSED_QUALITY_LABEL` is `"closed:quality"` here vs `"closed because of multiple quality violations"` there, same for `SUSPICIOUS_CHANGES_LABEL` and `TRIAGE_COMMENT_MARKER`. Since `pr_commands.py` uses its own private copies everywhere, these are effectively dead code with wrong values. Any future consumer importing from here would get the wrong strings. Was the plan to consolidate later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org