You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/03/17 20:11:11 UTC
[GitHub] [avro] martin-g commented on a change in pull request #1605: AVRO-3453 Add GeneratedCodeAttribute to generated code by avrogen
martin-g commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r829458587
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
+ {
+ GeneratedCodeAttribute generatedCodeAttribute =
+ new GeneratedCodeAttribute(System.AppDomain.CurrentDomain.FriendlyName,
+ System.Reflection.Assembly.GetExecutingAssembly().GetName().Version.ToString());
+
+ CodeAttributeDeclaration codeAttributeDeclaration =
+ new CodeAttributeDeclaration(generatedCodeAttribute.GetType().Name,
Review comment:
Same here
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
+ {
+ GeneratedCodeAttribute generatedCodeAttribute =
+ new GeneratedCodeAttribute(System.AppDomain.CurrentDomain.FriendlyName,
+ System.Reflection.Assembly.GetExecutingAssembly().GetName().Version.ToString());
Review comment:
These two lines should be indented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org