You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/11/20 13:42:59 UTC

Review Request 71793: RANGER-2648 : Provide policy list page url with service name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71793/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2648
    https://issues.apache.org/jira/browse/RANGER-2648


Repository: ranger


Description
-------

Currently, policy list page takes service id as the parameter. For example,
#http://localhost:6080/index.html#!/service/1/policies/0

Aim in this JIRA is to also support the URL with service name like below.
#http://localhost:6080/index.html#!/service/hdfs_service_1/policies/0

Both of the above should end up in the same page.
This will be useful, so that users can directly go to the right place in Ranger UI


Diffs
-----

  security-admin/src/main/webapp/scripts/controllers/Controller.js 523aadb 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 80277f6 


Diff: https://reviews.apache.org/r/71793/diff/1/


Testing
-------

Tested that both URLs redirect users to the same policy listing page.


Thanks,

Nitin Galave


Re: Review Request 71793: RANGER-2648 : Provide policy list page url with service name

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71793/#review218756
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Nov. 20, 2019, 1:42 p.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71793/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2019, 1:42 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2648
>     https://issues.apache.org/jira/browse/RANGER-2648
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently, policy list page takes service id as the parameter. For example,
> #http://localhost:6080/index.html#!/service/1/policies/0
> 
> Aim in this JIRA is to also support the URL with service name like below.
> #http://localhost:6080/index.html#!/service/hdfs_service_1/policies/0
> 
> Both of the above should end up in the same page.
> This will be useful, so that users can directly go to the right place in Ranger UI
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 523aadb 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 80277f6 
> 
> 
> Diff: https://reviews.apache.org/r/71793/diff/1/
> 
> 
> Testing
> -------
> 
> Tested that both URLs redirect users to the same policy listing page.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 71793: RANGER-2648 : Provide policy list page url with service name

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71793/#review218761
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Nov. 20, 2019, 1:42 p.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71793/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2019, 1:42 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2648
>     https://issues.apache.org/jira/browse/RANGER-2648
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently, policy list page takes service id as the parameter. For example,
> #http://localhost:6080/index.html#!/service/1/policies/0
> 
> Aim in this JIRA is to also support the URL with service name like below.
> #http://localhost:6080/index.html#!/service/hdfs_service_1/policies/0
> 
> Both of the above should end up in the same page.
> This will be useful, so that users can directly go to the right place in Ranger UI
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 523aadb 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 80277f6 
> 
> 
> Diff: https://reviews.apache.org/r/71793/diff/1/
> 
> 
> Testing
> -------
> 
> Tested that both URLs redirect users to the same policy listing page.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>