You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:52:46 UTC
[GitHub] [hudi] satishkotha opened a new pull request #1717: [HUDI-1012] Add unit test for snapshot reads
satishkotha opened a new pull request #1717:
URL: https://github.com/apache/hudi/pull/1717
## What is the purpose of the pull request
Adding a test for snapshot reads
## Brief change log
For MOR tables, there are tests for incremental reads. But tests are missing for snapshot reads. Add additional tests
## Verify this pull request
This change added tests and can be verified as follows:
Run TestHoodieMergeOnReadTable
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#issuecomment-640854839
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/97ab97b72635164db5ac2a4f93e72e224603ffe0&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1717 +/- ##
=========================================
Coverage 18.18% 18.18%
Complexity 857 857
=========================================
Files 348 348
Lines 15361 15361
Branches 1525 1525
=========================================
Hits 2794 2794
Misses 12209 12209
Partials 358 358
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=footer). Last update [97ab97b...59b1d02](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#issuecomment-640854839
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/97ab97b72635164db5ac2a4f93e72e224603ffe0&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1717 +/- ##
=========================================
Coverage 18.18% 18.18%
Complexity 857 857
=========================================
Files 348 348
Lines 15361 15361
Branches 1525 1525
=========================================
Hits 2794 2794
Misses 12209 12209
Partials 358 358
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=footer). Last update [97ab97b...59b1d02](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] satishkotha commented on a change in pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
satishkotha commented on a change in pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#discussion_r439037336
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java
##########
@@ -90,6 +90,8 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
public class TestHoodieMergeOnReadTable extends HoodieClientTestHarness {
Review comment:
I liked hudi-client because i could validate records contents in addition to metadata. But, thanks for the feedback, added sanity test in hadoop-mr as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash merged pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
n3nash merged pull request #1717:
URL: https://github.com/apache/hudi/pull/1717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#issuecomment-643719410
@n3nash Would you please merge the PR with [HUDI-XXX] as the prefix, thanks. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#issuecomment-640854839
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/97ab97b72635164db5ac2a4f93e72e224603ffe0&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1717 +/- ##
============================================
- Coverage 18.18% 18.14% -0.04%
- Complexity 857 859 +2
============================================
Files 348 352 +4
Lines 15361 15411 +50
Branches 1525 1525
============================================
+ Hits 2794 2797 +3
- Misses 12209 12256 +47
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/hudi/config/HoodieCompactionConfig.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUNvbXBhY3Rpb25Db25maWcuamF2YQ==) | `55.33% <0.00%> (-0.67%)` | `3.00% <0.00%> (ø%)` | |
| [...rg/apache/hudi/hadoop/HoodieROTablePathFilter.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZVJPVGFibGVQYXRoRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...g/apache/hudi/hadoop/HoodieParquetInputFormat.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL0hvb2RpZVBhcnF1ZXRJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...he/hudi/table/action/commit/UpsertPartitioner.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9VcHNlcnRQYXJ0aXRpb25lci5qYXZh) | `55.39% <0.00%> (ø)` | `15.00% <0.00%> (ø%)` | |
| [...hudi/hadoop/hive/HoodieCombineHiveInputFormat.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL2hpdmUvSG9vZGllQ29tYmluZUhpdmVJbnB1dEZvcm1hdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../hadoop/realtime/AbstractRealtimeRecordReader.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0Fic3RyYWN0UmVhbHRpbWVSZWNvcmRSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../hadoop/realtime/RealtimeUnmergedRecordReader.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL1JlYWx0aW1lVW5tZXJnZWRSZWNvcmRSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...hadoop/realtime/RealtimeCompactedRecordReader.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL1JlYWx0aW1lQ29tcGFjdGVkUmVjb3JkUmVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...oop/realtime/HoodieParquetRealtimeInputFormat.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZVBhcnF1ZXRSZWFsdGltZUlucHV0Rm9ybWF0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...op/realtime/HoodieCombineRealtimeRecordReader.java](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZUNvbWJpbmVSZWFsdGltZVJlY29yZFJlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/hudi/pull/1717/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=footer). Last update [97ab97b...ca59071](https://codecov.io/gh/apache/hudi/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on a change in pull request #1717: [HUDI-1012] Add unit test for snapshot reads
Posted by GitBox <gi...@apache.org>.
n3nash commented on a change in pull request #1717:
URL: https://github.com/apache/hudi/pull/1717#discussion_r438900358
##########
File path: hudi-client/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java
##########
@@ -90,6 +90,8 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
public class TestHoodieMergeOnReadTable extends HoodieClientTestHarness {
Review comment:
@satishkotha Does this test make sense to add to hudi-hadoop-mr where the inputformats are being tested ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org