You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2013/01/10 13:11:51 UTC
svn commit: r1431314 - in
/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal:
as/codegen/TestComments.java js/codegen/goog/TestGoogComments.java
Author: erikdebruin
Date: Thu Jan 10 12:11:50 2013
New Revision: 1431314
URL: http://svn.apache.org/viewvc?rev=1431314&view=rev
Log:
- created tests for AS comments (which seem to be parsed out by the compiler, so nothing much to test... yet?)
Added:
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java (with props)
flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java (with props)
Added: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java?rev=1431314&view=auto
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java (added)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java Thu Jan 10 12:11:50 2013
@@ -0,0 +1,87 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.flex.compiler.internal.as.codegen;
+
+import org.apache.flex.compiler.tree.as.IFileNode;
+import org.apache.flex.compiler.tree.as.IFunctionNode;
+import org.junit.Ignore;
+import org.junit.Test;
+
+/**
+ * @author Erik de Bruin
+ */
+public class TestComments extends TestWalkerBase
+{
+ // TODO (erikdebruin/mschmalle) why aren't comments preserved?
+
+ @Ignore
+ @Test
+ public void testComment_SingleLine()
+ {
+ IFunctionNode node = getMethod("function a():void {// single line comment};");
+ visitor.visitFunction(node);
+ assertOut("function a():void {\n\t// single line comment\n}");
+ }
+
+ @Ignore
+ @Test
+ public void testComment_SingleLine_After()
+ {
+ IFunctionNode node = getMethod("function a():void {var a:String = ''; // single line comment};");
+ visitor.visitFunction(node);
+ assertOut("function a():void {\n\tvar a:String = ''; // single line comment\n}");
+ }
+
+ @Ignore
+ @Test
+ public void testComment_MultiLine()
+ {
+ IFunctionNode node = getMethod("function a():void {/*first line comment\nsecond line comment*/};");
+ visitor.visitFunction(node);
+ assertOut("function a():void {\n\t/*first line comment\n\tsecond line comment*/\n}");
+ }
+
+ @Ignore
+ @Test
+ public void testComment_InLine()
+ {
+ IFunctionNode node = getMethod("function a():void {var a:String /* inline comment */ = 'Hello world';};");
+ visitor.visitFunction(node);
+ assertOut("function a():void {\n\tvar a:String /* inline comment */ = 'Hello world';\n}");
+ }
+
+ @Ignore
+ @Test
+ public void testComment_ASDoc()
+ {
+ IFunctionNode node = getMethod("function a():void {/**\n * line comment\n */};");
+ visitor.visitFunction(node);
+ assertOut("function a():void {\n\t/**\n\t * line comment\n\t */};");
+ }
+
+ protected IFunctionNode getMethod(String code)
+ {
+ String source = "package {public class A {" + code + "}}";
+ IFileNode node = getFileNode(source);
+ IFunctionNode child = (IFunctionNode) findFirstDescendantOfType(node,
+ IFunctionNode.class);
+ return child;
+ }
+}
Propchange: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestComments.java
------------------------------------------------------------------------------
svn:eol-style = native
Added: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java?rev=1431314&view=auto
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java (added)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java Thu Jan 10 12:11:50 2013
@@ -0,0 +1,39 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.flex.compiler.internal.js.codegen.goog;
+
+import org.apache.flex.compiler.clients.IBackend;
+import org.apache.flex.compiler.internal.as.codegen.TestComments;
+import org.apache.flex.compiler.internal.js.driver.goog.GoogBackend;
+
+/**
+ * @author Erik de Bruin
+ */
+public class TestGoogComments extends TestComments
+{
+ // TODO (erikdebruin) if comments aren't preserved in the base tests
+ // we can't test the 'goog' equivalents
+
+ @Override
+ protected IBackend createBackend()
+ {
+ return new GoogBackend();
+ }
+}
Propchange: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogComments.java
------------------------------------------------------------------------------
svn:eol-style = native