You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/09/12 16:13:44 UTC
[PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
andygrove opened a new pull request, #941:
URL: https://github.com/apache/datafusion-comet/pull/941
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/datafusion-comet/issues/721
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I am requesting that ASF INFRA sets up Nexus access for the DataFusion project so that we can publish Maven artifacts. The normal convention for maven group ids for Apache projects is org.apache.projectname, so I think we need to revisit changing our Maven group ids (<groupId> in the pom.xml) from org.apache.comet to org.apache.datafusion. The DataFusion project could hypothetically want to publish Java bindings to Maven in the future as well. The artifact names would not change and there is no need to change package names in the code.
Note that we did previously discuss this back in https://github.com/apache/datafusion-comet/pull/278.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2349585411
Infra also mentioned that we should perform a Podling name search at some point to check whether Comet is allowable as a TLP. Comet components are already in other Apache projects (Apache Tomcat and Apache Tuscany).
https://incubator.apache.org/guides/names.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2354032060
> This will presumably affect the dependency in iceberg that we are proposing to add.
@parthchandra Do I need to change anything on iceberg side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2349382137
> I had a brief discussion with ASF infra and they said that the Maven group ID should be `org.apache.TLPNAME`
Well, that settles it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2347340187
> @andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this). is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.
I had a brief discussion with ASF infra and they said that the Maven group ID should be `org.apache.TLPNAME` although there are exceptions to that. If we want to use a different TLPNAME then I think we will need to have a conversation with ASF infra to request an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2346752606
@huaxingao This will presumably affect the dependency in iceberg that we are proposing to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2354076851
> > This will presumably affect the dependency in iceberg that we are proposing to add.
>
> @parthchandra Do I need to change anything on iceberg side?
The dependency will change from `org.apache.comet:comet-spark` to `org.apache.datafusion:comet-spark` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Change maven group ID to `org.apache.datafusion` [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #941:
URL: https://github.com/apache/datafusion-comet/pull/941#issuecomment-2346766267
@andygrove the previous discussion on this is still relevant (I don't have a strong opinion on this).
is it still possible for the DataFusion project to publish to multiple maven group ids or does the Nexus repository setup only allow a single group id per project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org