You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/10 11:23:41 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4483: [BugFix]
Docker InfluxDB cannot be enable
kezhenxu94 opened a new pull request #4483: [BugFix] Docker InfluxDB cannot be enable
URL: https://github.com/apache/skywalking/pull/4483
### Motivation:
This patch fixes the bug that there's no chance to enable the InfluxDB storage in docker container.
### Modifications:
Generate InfluxDB configuration section to enable it.
### Result:
Users can enable InfluxDB by specifying SW_STORAGE=influxdb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4483: [BugFix] Docker
InfluxDB cannot be enabled
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4483: [BugFix] Docker InfluxDB cannot be enabled
URL: https://github.com/apache/skywalking/pull/4483#issuecomment-597097770
Why you merge this PR as CI breaks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4483: [BugFix] Docker
InfluxDB cannot be enabled
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4483: [BugFix] Docker InfluxDB cannot be enabled
URL: https://github.com/apache/skywalking/pull/4483#issuecomment-597050063
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=h1) Report
> Merging [#4483](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ab8d7fab23b69593d7d06bdee20421006cb20189?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4483 +/- ##
==========================================
- Coverage 24.97% 24.95% -0.03%
==========================================
Files 1231 1231
Lines 28496 28496
Branches 3905 3905
==========================================
- Hits 7118 7110 -8
- Misses 20719 20726 +7
- Partials 659 660 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4483/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4483/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55% <0%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=footer). Last update [ab8d7fa...d49310b](https://codecov.io/gh/apache/skywalking/pull/4483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4483: [BugFix] Docker
InfluxDB cannot be enabled
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4483: [BugFix] Docker InfluxDB cannot be enabled
URL: https://github.com/apache/skywalking/pull/4483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr removed a comment on issue #4483: [BugFix]
Docker InfluxDB cannot be enabled
Posted by GitBox <gi...@apache.org>.
dmsolr removed a comment on issue #4483: [BugFix] Docker InfluxDB cannot be enabled
URL: https://github.com/apache/skywalking/pull/4483#issuecomment-597057939
beginning to refactor e2e framework?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4483: [BugFix] Docker
InfluxDB cannot be enabled
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4483: [BugFix] Docker InfluxDB cannot be enabled
URL: https://github.com/apache/skywalking/pull/4483#issuecomment-597057939
beginning to refactor e2e framework?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services