You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/18 18:59:21 UTC

[GitHub] [incubator-hudi] xushiyan opened a new pull request #1640: [WIP] remove -Xms

xushiyan opened a new pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r428110614



##########
File path: pom.xml
##########
@@ -245,7 +245,8 @@
         <version>${maven-surefire-plugin.version}</version>
         <configuration>
           <skip>${skipUTs}</skip>
-          <argLine>-Xms256m -Xmx2g</argLine>
+          <argLine>-Xmx2g</argLine>

Review comment:
       @vinothchandar noted. I'll make sure message is self-explanatory onwards.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-io commented on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630495938


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...30901b1](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r427746163



##########
File path: pom.xml
##########
@@ -245,7 +245,8 @@
         <version>${maven-surefire-plugin.version}</version>
         <configuration>
           <skip>${skipUTs}</skip>
-          <argLine>-Xms256m -Xmx2g</argLine>
+          <argLine>-Xmx2g</argLine>

Review comment:
       Trying to improve the config as well...thinking -Xms it is not needed. And below this line, extending process exit timeout from 30 to 120 sec should be safe to do. I can also revert the `pom.xml` if you prefer separate the changes from this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/e6f3bf10cf2c62a1008b82765abdcd33cfd64c67&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.60%   16.60%           
     Complexity      800      800           
   =========================================
     Files           344      344           
     Lines         15172    15172           
     Branches       1512     1512           
   =========================================
     Hits           2520     2520           
     Misses        12320    12320           
     Partials        332      332           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [e6f3bf1...e292335](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r427956293



##########
File path: pom.xml
##########
@@ -245,7 +245,8 @@
         <version>${maven-surefire-plugin.version}</version>
         <configuration>
           <skip>${skipUTs}</skip>
-          <argLine>-Xms256m -Xmx2g</argLine>
+          <argLine>-Xmx2g</argLine>

Review comment:
       its fine for now.. but we can split the PRs next time.. 
   
   Also appreciate if you added a more descriptive commit message (we need to standardize this as a group) 

##########
File path: pom.xml
##########
@@ -245,7 +245,8 @@
         <version>${maven-surefire-plugin.version}</version>
         <configuration>
           <skip>${skipUTs}</skip>
-          <argLine>-Xms256m -Xmx2g</argLine>
+          <argLine>-Xmx2g</argLine>

Review comment:
       its fine for now.. but we can split the PRs next time.. 
   
   Also appreciate if you added a more descriptive commit message (we need to standardize this as a group) :) 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...2b005ea](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/e6f3bf10cf2c62a1008b82765abdcd33cfd64c67&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.60%   16.60%           
     Complexity      800      800           
   =========================================
     Files           344      344           
     Lines         15172    15172           
     Branches       1512     1512           
   =========================================
     Hits           2520     2520           
     Misses        12320    12320           
     Partials        332      332           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [e6f3bf1...e292335](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] vinothchandar merged pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...98cf454](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1640      +/-   ##
   ============================================
   - Coverage     16.59%   16.58%   -0.02%     
   + Complexity      798      797       -1     
   ============================================
     Files           344      344              
     Lines         15160    15160              
     Branches       1510     1510              
   ============================================
   - Hits           2516     2514       -2     
   - Misses        12314    12316       +2     
     Partials        330      330              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1640/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...e092b32](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...2b005ea](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] xushiyan commented on pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630599944


   cc @bvaradar 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter commented on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...30901b1](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1640: [MINOR] Fix resource cleanup in TestTableSchemaEvolution

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#discussion_r427729264



##########
File path: pom.xml
##########
@@ -245,7 +245,8 @@
         <version>${maven-surefire-plugin.version}</version>
         <configuration>
           <skip>${skipUTs}</skip>
-          <argLine>-Xms256m -Xmx2g</argLine>
+          <argLine>-Xmx2g</argLine>

Review comment:
       this seems like change carried over from the other PR? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hudi] codecov-commenter edited a comment on pull request #1640: [WIP] travis jvm fork issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1640:
URL: https://github.com/apache/incubator-hudi/pull/1640#issuecomment-630496124


   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=h1) Report
   > Merging [#1640](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/2600d2de8d9d963db920ff486032482a946fe3d6&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1640/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1640   +/-   ##
   =========================================
     Coverage     16.59%   16.59%           
     Complexity      798      798           
   =========================================
     Files           344      344           
     Lines         15160    15160           
     Branches       1510     1510           
   =========================================
     Hits           2516     2516           
     Misses        12314    12314           
     Partials        330      330           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=footer). Last update [2600d2d...98cf454](https://codecov.io/gh/apache/incubator-hudi/pull/1640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org