You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/18 19:32:07 UTC
[GitHub] [incubator-echarts] nsmgr8 opened a new pull request #12168:
fix(toolbox): only change title of requested feature. closes #12162
nsmgr8 opened a new pull request #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Fixes the toolbox title issue described in #12162
### Fixed issues
<!--
- #xxxx: ...
-->
- #12162
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
After toggling magicType icons, titles in other features in toolbox become `[object Object]`. This is becaues the event fired a new title change and it was overwriting all features.
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
The event also sends which feature to change the title.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on issue #12168:
fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-588199977
Nice fix! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] nsmgr8 commented on issue #12168: fix(toolbox):
only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
nsmgr8 commented on issue #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-602087710
May I know why this was not included in 4.7.0 release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12168:
fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-588199977
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12168:
fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-587711983
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12168:
fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12168:
fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12168: fix(toolbox): only change title of requested feature. closes #12162
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-588200023
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] sinpor commented on pull request #12168: fix(toolbox): only change title of requested feature. closes #12162
Posted by GitBox <gi...@apache.org>.
sinpor commented on pull request #12168:
URL: https://github.com/apache/incubator-echarts/pull/12168#issuecomment-633762943
@nsmgr8 The 4.8.0 has been resolved.🐛
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org