You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 10:59:09 UTC
[GitHub] [airflow] andreaslang opened a new pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
andreaslang opened a new pull request #21456:
URL: https://github.com/apache/airflow/pull/21456
Allow the configuration of maintenance windows for databricks submit and run now operators. The reason is that according to databricks support during these times any error on the API can happen. In our case we got 403s. To work around that we expand the existing retry mechanism during maintenance window to consider any error retryable.
closes: #21286
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#issuecomment-1033633325
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#discussion_r802544585
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -112,6 +115,36 @@ def __repr__(self) -> str:
return str(self.__dict__)
+class WeekDay(Enum):
+ """Utility class to specify the weekday for maintenance."""
+ Mon = 0
+ Tue = 1
+ Wed = 2
+ Thu = 3
+ Fri = 4
+ Say = 5
+ Sun = 6
Review comment:
We already have enum for that
https://github.com/apache/airflow/blob/1a8a897120762692ca98ac5ce4da881678c073aa/airflow/utils/weekday.py#L23-L32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andreaslang commented on a change in pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
andreaslang commented on a change in pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#discussion_r802564718
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -112,6 +115,36 @@ def __repr__(self) -> str:
return str(self.__dict__)
+class WeekDay(Enum):
+ """Utility class to specify the weekday for maintenance."""
+ Mon = 0
+ Tue = 1
+ Wed = 2
+ Thu = 3
+ Fri = 4
+ Say = 5
+ Sun = 6
Review comment:
OK, that is that, using the existing enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#discussion_r802544585
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -112,6 +115,36 @@ def __repr__(self) -> str:
return str(self.__dict__)
+class WeekDay(Enum):
+ """Utility class to specify the weekday for maintenance."""
+ Mon = 0
+ Tue = 1
+ Wed = 2
+ Thu = 3
+ Fri = 4
+ Say = 5
+ Sun = 6
Review comment:
We already have enum for that
https://github.com/apache/airflow/blob/main/airflow/utils/weekday.py#L23-L32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#issuecomment-1052505864
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andreaslang commented on pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
andreaslang commented on pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#issuecomment-1054040698
I am actually closing this issue, since putting it up databricks has come back to me and given a much better timeline than expected to fix it (hopefully close to March 2nd).
Hence it should not be necessary anymore to work around the wrong return codes during maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andreaslang commented on a change in pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
andreaslang commented on a change in pull request #21456:
URL: https://github.com/apache/airflow/pull/21456#discussion_r802555410
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -112,6 +115,36 @@ def __repr__(self) -> str:
return str(self.__dict__)
+class WeekDay(Enum):
+ """Utility class to specify the weekday for maintenance."""
+ Mon = 0
+ Tue = 1
+ Wed = 2
+ Thu = 3
+ Fri = 4
+ Say = 5
+ Sun = 6
Review comment:
Did not know about that one, will change the PR to use the existing enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andreaslang closed pull request #21456: Databricks Submit/RunNow operator improved maintenance window handling
Posted by GitBox <gi...@apache.org>.
andreaslang closed pull request #21456:
URL: https://github.com/apache/airflow/pull/21456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org