[GitHub] [superset] Steejay commented on issue #10330: [SQL Lab] Add an alert in SQL Lab when results are limited

[GitBox <gi...@apache.org>]

Steejay commented on issue #10330:
URL: https://github.com/apache/superset/issues/10330#issuecomment-776844480


   thanks for bringing up this edge case @eschutho 
   
   • When more than one condition are true for [admins](https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=133%3A70) and [non admins](https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=133%3A212)
   
   For these conditions, the configuration in the message is always behind a tooltip. ie if [query = display_max_row](https://www.figma.com/file/5db2MpaKNnC1c7MK9ysdeV/SQL-Limit-Indicator?node-id=135%3A333)
   
   Reasoning: show what is visible in the UI first (query/dropdown) so that users can establish a visual relationship and use progressive disclosure to reveal additional matching limit constraints on the server side (configs). 
   
   
   cc @yousoph 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org