[GitHub] [airflow] potiuk commented on a diff in pull request #29469: Updates to provider release verification documentation and check_files to produce a more useful Dockerfile

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #29469:
URL: https://github.com/apache/airflow/pull/29469#discussion_r1103228230


##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -561,14 +561,41 @@ Or update it if you already checked it out:
 svn update .
 ```
 
-Optionally you can use `check_files.py` script to verify that all expected files are
-present in SVN. This script may help also with verifying installation of the packages.
+Optionally you can use the [`check_files.py`](https://github.com/apache/airflow/blob/main/dev/check_files.py)
+script to verify that all expected files are present in SVN. This script will produce a `Dockerfile.pmc` which
+may help with verifying installation of the packages.
 
 ```shell script
 # Copy the list of packages (pypi urls) into `packages.txt` then run:
 python check_files.py providers -p {PATH_TO_SVN}
 ```
 
+After the above script completes you can build `Dockerfile.pmc` to trigger an installation of each provider
+package:
+
+```shell script
+docker build - < Dockerfile.pmc
+```
+
+**Note**: This may fail to install some providers. For example, if they require some system level dependencies
+that aren't present in the image. If you wish to investigate you may update the Dockerfile to install any
+missing dependencies and then try to build again.
+
+For example, currently `apache-airflow-providers-apache-hive` requires the `libsasl2` system dependency. To

Review Comment:
   If we replace `FROM apache/airflow:latest` with `FROM  ghcr.io/apache/airflow/main/ci/python3.10` or smth - that might be not needed any more. The CI image has all that is needed.
   
   Also I've been thinking about releasing "fat" airflow image - as opposed to "slim" (go figure). Several users would have less problems if we had one. This might be the right long-term solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org