You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/16 16:07:25 UTC
[GitHub] [netbeans] sdedic opened a new pull request #3793: Maven error/warnings refactored to use Parsing API.
sdedic opened a new pull request #3793:
URL: https://github.com/apache/netbeans/pull/3793
Originally I was trying to bridge project problems to LSP. During the course I have realized that Maven's errors, underlined in the editor, are provided by `UpToDateStatusProvider` implementation - this one is in charge or reporting start/stop computations in annotation's gutter.
The Provider however monitored **on-disk file changes**, so potential errors were only reported after file save, not (as usual) when a change to the opened document has been made by the user. This approach bypasses alll the machinery of Parsing API which is more suitable for tracking document changes and/or caret/selection in the live document. In addition, this approach wouldn't work in the LSP client scenario at all.
The StatusProvider implementation was broken anyway as for example [StatusProvider](https://github.com/sdedic/incubator-netbeans/blob/master/java/maven.hints/src/org/netbeans/modules/maven/hints/pom/StatusProvider.java#L284) kept the status `UP_TO_DATE_PROCESSING` if there was a non-empty selection ... The `UpToDateStatusProvider` + hints is generally broken, see [NETBEANS-6477](https://issues.apache.org/jira/browse/NETBEANS-6477). I will not fix that in this PR.
The PR adapts Maven implementation to use Parsing API - this allows to react immediately, and since I provided a custom `ModelSource` (see `M2S` class) to maven processing, even the live editor content can be analyzed by the Maven library.
Tests for this module were broken - test data file was missing; I've created some + added necessary env setup so the test passes now.
I've also discovered that Tasklist Maven integration is broken for some time - see [NETBEANS-6476](https://issues.apache.org/jira/browse/NETBEANS-6476), will not fix in this PR either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3793: Maven error/warnings refactored to use Parsing API.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3793:
URL: https://github.com/apache/netbeans/pull/3793#issuecomment-1072269999
Sorry :( I've accidentally committed here changes that belong to other PR; reverted back to the reviewed state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3793: Maven error/warnings refactored to use Parsing API.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3793:
URL: https://github.com/apache/netbeans/pull/3793#issuecomment-1072269999
Sorry :( I've accidentally committed here changes that belong to other PR; reverted back to the reviewed state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #3793: Maven error/warnings refactored to use Parsing API.
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #3793:
URL: https://github.com/apache/netbeans/pull/3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists