You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Rohini Palaniswamy (JIRA)" <ji...@apache.org> on 2012/10/28 19:55:12 UTC
[jira] [Created] (PIG-3013) BinInterSedes improve chararray sort
performance
Rohini Palaniswamy created PIG-3013:
---------------------------------------
Summary: BinInterSedes improve chararray sort performance
Key: PIG-3013
URL: https://issues.apache.org/jira/browse/PIG-3013
Project: Pig
Issue Type: Bug
Affects Versions: 0.10.0
Reporter: Rohini Palaniswamy
Assignee: Rohini Palaniswamy
Fix For: 0.12
In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-3013:
------------------------------------
Status: Patch Available (was: Open)
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-3013:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Checked into trunk. Thanks for the reminder Gianmarco.
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485703#comment-13485703 ]
Jonathan Coveney commented on PIG-3013:
---------------------------------------
+1 for trunk
regarding inclusion in 0.11, as much as I want to say we should, the "apache" part of me says we should follow the line in the sand we drew for 0.11 and try to get it out or else we're just going to be too tempted to keep dumping new stuff there.
Does anyone else feel differently?
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490056#comment-13490056 ]
Gianmarco De Francisci Morales commented on PIG-3013:
-----------------------------------------------------
This seems ready to be committed to trunk.
[~rohini] do you want to commit it yourself?
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohini Palaniswamy updated PIG-3013:
------------------------------------
Attachment: PIG-3013.patch
Ran the full suite of unit tests and they passed (no new errors than the pending ones in PIg-2972). Did not add a new unit test as TestOrderBy3.testValuesASC and testValuesDESC already test the ordering for chararray and exercise this codepath.
[~jcoveney],
Do you want to include this in 0.11 as well?
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Rohini Palaniswamy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485705#comment-13485705 ]
Rohini Palaniswamy commented on PIG-3013:
-----------------------------------------
No problem Jon. That's why marked it for 0.12. Was checking just in case.
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
> Attachments: PIG-3013.patch
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3013) BinInterSedes improve chararray sort
performance
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485688#comment-13485688 ]
Jonathan Coveney commented on PIG-3013:
---------------------------------------
Excellent
> BinInterSedes improve chararray sort performance
> ------------------------------------------------
>
> Key: PIG-3013
> URL: https://issues.apache.org/jira/browse/PIG-3013
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Rohini Palaniswamy
> Assignee: Rohini Palaniswamy
> Fix For: 0.12
>
>
> In PIG-2975, Koji found that there is a extra array copy during byte array comparison and fixing that gave a 15-20% performance improvement. Same is the case with chararray.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira