You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/19 11:49:16 UTC

[GitHub] eolivelli commented on a change in pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.

eolivelli commented on a change in pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.
URL: https://github.com/apache/bookkeeper/pull/1888#discussion_r242887704
 
 

 ##########
 File path: site/_data/config/bk_server.yaml
 ##########
 @@ -538,6 +538,9 @@ groups:
         - Twitter Ostrich   : org.apache.bookkeeper.stats.twitter.ostrich.OstrichProvider
         - Twitter Science   : org.apache.bookkeeper.stats.twitter.science.TwitterStatsProvider
     default: org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
+  - param: limitStatsLogging
+    description: option to limit stats logging
 
 Review comment:
   Honestly from this description I can't understand what 'stats logging' really means in this context.
   It seems that we are disabling stats at all
   
   @sijie @reddycharan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services