[jira] [Comment Edited] (FLINK-14164) Add a metric to show failover count regarding fine grained recovery

["Zhu Zhu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-14164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936671#comment-16936671 ] 

Zhu Zhu edited comment on FLINK-14164 at 9/24/19 11:10 AM:
-----------------------------------------------------------

>> So maybe we could say that fullRestart is actually numberOfRestarts and let the fine grained failover strategy increment fullRestart in case of a restart. Moreover, we could deprecate this metric and introduce numberOfRestarts. That way we could remove fullRestart with Flink 1.11.

Agreed. Should we have the change on {{fullRestart}} for 1.9? If so, we may need to start the work right now since 1.9.1 is on the way.


was (Author: zhuzh):
>> So maybe we could say that fullRestart is actually numberOfRestarts and let the fine grained failover strategy increment fullRestart in case of a restart. Moreover, we could deprecate this metric and introduce numberOfRestarts. That way we could remove fullRestart with Flink 1.11.

Agreed. Should we have the change on {{fullRestart}} for 1.9? If so, I think we should start the work now since 1.9.1 is on the way.

> Add a metric to show failover count regarding fine grained recovery
> -------------------------------------------------------------------
>
>                 Key: FLINK-14164
>                 URL: https://issues.apache.org/jira/browse/FLINK-14164
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination, Runtime / Metrics
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Zhu Zhu
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Previously Flink uses restart all strategy to recover jobs from failures. And the metric "fullRestart" is used to show the count of failovers.
> However, with fine grained recovery introduced in 1.9.0, the "fullRestart" metric only reveals how many times the entire graph has been restarted, not including the number of fine grained failure recoveries.
> As many users want to build their job alerting based on failovers, I'd propose to add such a new metric {{numberOfFailures}}/{{numberOfRestarts}} which also respects fine grained recoveries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)