You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/02/27 09:18:10 UTC

Review Request 31530: HIVE-9809 Fix FindBugs found bugs in hive-exec

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31530/
-----------------------------------------------------------

Review request for hive, Brock Noland, Alan Gates, Jason Dere, Thejas Nair, and Xuefu Zhang.


Bugs: HIVE-9809
    https://issues.apache.org/jira/browse/HIVE-9809


Repository: hive-git


Description
-------

HIVE-9809 Fix FindBugs found bugs in hive-exec


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 8e1e6e2b4f29a2499845df1f565dbb6859b262a8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 089bd941f391f33ead3bd638854624fe20186065 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultUDAFEvaluatorResolver.java c2f9fa78db3a233fe9d53d641b3956c9a863d53c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java 48ce67ad8bbea0fd32a306e6ac0bd8676438f65b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java a5722bfcb195139761b03443841bdcd3f37b5b1a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 80ce96a19dd2e3f59cebb5bbc6bfa322ce3faa37 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java c6bfd03c1d647ff008f2ad94bc81b31eb5a5f7cf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java bc915294f62dc543afa503e79a65655c960939cd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 6f6f5fa6fe8e84d62f1a0e6ac191f82b488b7554 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java d0693efb1b95353497fdc67f0684a1549e5faa14 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 6a6593c3ac4890d7e169b5af6608aee66679933a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java a93f1f21a7ec10b58713678fdd0a31307f6fb182 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java b7e81423233bebedad04fdeaa7aa228e407df335 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 64b1e420a1447e5548fb0beb395758bd461f4675 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java fe75ce3d3b14b84d023612c00554729e793dc677 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3 
  ql/src/java/org/apache/hadoop/hive/ql/io/VectorizedRCFileRecordReader.java 597aef6af1bfcf228bc39103c204330337641678 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationUtilities.java 17364c3c78189b48b57dcb17c3fe7828204cd80f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPruner.java 33b6e8614372fa41f368867088ad87ac4c41a339 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a347fbb5237774d7661498246a37139103b1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HashTableSinkDesc.java 03ef70485b71c70fccae3b4ac501120f606a4936 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 990608a4864b9fac2d5bb308b0f7a01faf6088fd 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java 9fdd417a5f6dc7199658351b3b149484105e2815 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 0249a1c098e2b9b363ebadffb9d6278c59f33119 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java 66778e049f4dde82b0ea96ba5c5b9282ff01c0bd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java cebaf45cdb1094238624d5fde018a3bdaf19c2f0 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java 78cd5cd0234792fa0d9c1ed4e9acadca182f8d8d 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatchCtx.java f7fea17b6037bab15fe53f8c8ef51e92c95de4e5 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFileDump.java 00afdac274d390dc6605c266b29a0ae490c54910 

Diff: https://reviews.apache.org/r/31530/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Re: Review Request 31530: HIVE-9809 Fix FindBugs found bugs in hive-exec

Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31530/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 7:27 p.m.)


Review request for hive, Brock Noland, Alan Gates, Jason Dere, Thejas Nair, and Xuefu Zhang.


Changes
-------

removed changes in *Desc and *Operator clases


Bugs: HIVE-9809
    https://issues.apache.org/jira/browse/HIVE-9809


Repository: hive-git


Description
-------

HIVE-9809 Fix FindBugs found bugs in hive-exec


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 8e1e6e2b4f29a2499845df1f565dbb6859b262a8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 089bd941f391f33ead3bd638854624fe20186065 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultUDAFEvaluatorResolver.java c2f9fa78db3a233fe9d53d641b3956c9a863d53c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java 48ce67ad8bbea0fd32a306e6ac0bd8676438f65b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java a5722bfcb195139761b03443841bdcd3f37b5b1a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 6f6f5fa6fe8e84d62f1a0e6ac191f82b488b7554 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java d0693efb1b95353497fdc67f0684a1549e5faa14 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 6a6593c3ac4890d7e169b5af6608aee66679933a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java a93f1f21a7ec10b58713678fdd0a31307f6fb182 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java b7e81423233bebedad04fdeaa7aa228e407df335 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 64b1e420a1447e5548fb0beb395758bd461f4675 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java fe75ce3d3b14b84d023612c00554729e793dc677 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetLong.java 5779fb35d7ffbc67917cdcd66b1c57baa3e2bff3 
  ql/src/java/org/apache/hadoop/hive/ql/io/VectorizedRCFileRecordReader.java 597aef6af1bfcf228bc39103c204330337641678 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationUtilities.java 17364c3c78189b48b57dcb17c3fe7828204cd80f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPruner.java 33b6e8614372fa41f368867088ad87ac4c41a339 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractOperatorDesc.java 52280ccce9742ab03cea6c7957da17752c0b404e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 1737a347fbb5237774d7661498246a37139103b1 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 0249a1c098e2b9b363ebadffb9d6278c59f33119 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java 66778e049f4dde82b0ea96ba5c5b9282ff01c0bd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java cebaf45cdb1094238624d5fde018a3bdaf19c2f0 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java 78cd5cd0234792fa0d9c1ed4e9acadca182f8d8d 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatchCtx.java f7fea17b6037bab15fe53f8c8ef51e92c95de4e5 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFileDump.java 00afdac274d390dc6605c266b29a0ae490c54910 

Diff: https://reviews.apache.org/r/31530/diff/


Testing
-------


Thanks,

Alexander Pivovarov