Re: [PR] feat: Support meta_server connect to Kerberos sasl authenticated Zookeeper where KDC configured 'rdns = false' [incubator-pegasus]

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1864:
URL: https://github.com/apache/incubator-pegasus/pull/1864#discussion_r1459062203


##########
src/zookeeper/zookeeper_session.cpp:
##########
@@ -43,6 +44,10 @@ DSN_DEFINE_string(security,
                   zookeeper_kerberos_service_name,
                   "zookeeper",
                   "zookeeper kerberos service name");
+DSN_DEFINE_string(security,
+                  zookeeper_sasl_service_fqdn,
+                  "",
+                  "The fqdn of sasl server name which one connect to zookeeper service");

Review Comment:
   Is it?
   ```suggestion
                     "The fqdn of the first host in [zookeeper] hosts_list");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org