[jira] [Commented] (BIGTOP-2374) Toolchain needs clear warning for Puppet <3

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313804#comment-15313804 ] 

Konstantin Boudnik commented on BIGTOP-2374:
--------------------------------------------

This is pretty cool! +1 Like it! Will commit in the morning. Thanks [~sekikn]!

> Toolchain needs clear warning for Puppet <3
> -------------------------------------------
>
>                 Key: BIGTOP-2374
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2374
>             Project: Bigtop
>          Issue Type: Bug
>          Components: toolchain
>    Affects Versions: 1.1.0
>            Reporter: Konstantin Boudnik
>            Assignee: Kengo Seki
>             Fix For: 1.2.0
>
>         Attachments: BIGTOP-2374.1.patch
>
>
> Took me a while to figure out why puppet modules aren't getting installed. The reason is this silent fallback
> {code}
>     onlyif => "test `facter puppetversion |cut -d'.' -f 1` -ge 3",
> {code}
> in the {{bigtop_toolchain/manifests/puppet-modules.pp}}
> We need to issue a clear warning instead of falling quietly - it is a bad UX.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)