You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 15:07:58 UTC

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #130: [FLINK-26214] Support cross platform image builds

Aitozi commented on a change in pull request #130:
URL: https://github.com/apache/flink-kubernetes-operator/pull/130#discussion_r837592608



##########
File path: Dockerfile
##########
@@ -35,7 +36,7 @@ COPY $WEBHOOK_DIR/src ./$WEBHOOK_DIR/src
 
 COPY tools ./tools
 
-RUN --mount=type=cache,target=/root/.m2 mvn -ntp clean install
+RUN --mount=type=cache,target=/root/.m2 mvn -ntp clean install -DskipTests=$SKIP_TESTS

Review comment:
       I have also think about this, can we just mvn build when building docker image, Because the CI already run the test. (Make the `Build with Maven` not skipTests as now)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org