You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/08 15:37:31 UTC
[GitHub] [spark] tomvanbussel commented on a change in pull request #24011:
[SPARK-27071][CORE] Expose additional metrics in status.api.v1.StageData
tomvanbussel commented on a change in pull request #24011: [SPARK-27071][CORE] Expose additional metrics in status.api.v1.StageData
URL: https://github.com/apache/spark/pull/24011#discussion_r263820881
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
##########
@@ -433,13 +433,13 @@ private[ui] class StageDataSource(
}
val formattedDuration = duration.map(d => UIUtils.formatDuration(d)).getOrElse("Unknown")
- val inputRead = stageData.inputBytes
+ val inputRead = stageData.metrics.inputMetrics.bytesRead
val inputReadWithUnit = if (inputRead > 0) Utils.bytesToString(inputRead) else ""
- val outputWrite = stageData.outputBytes
+ val outputWrite = stageData.metrics.outputMetrics.bytesWritten
val outputWriteWithUnit = if (outputWrite > 0) Utils.bytesToString(outputWrite) else ""
- val shuffleRead = stageData.shuffleReadBytes
+ val shuffleRead = stageData.metrics.shuffleReadMetrics.bytesRead
val shuffleReadWithUnit = if (shuffleRead > 0) Utils.bytesToString(shuffleRead) else ""
- val shuffleWrite = stageData.shuffleWriteBytes
+ val shuffleWrite = stageData.metrics.shuffleWriteMetrics.recordsWritten
Review comment:
Oops, I should not trust autocompletion. Fixed! Thanks for catching this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org