You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Emmanuel Bourg <e....@cross-systems.fr> on 2003/06/27 16:46:29 UTC
[digester][patch] CallMethodRuleTestCase clean up
Hi, i'm proposing a patch to fix some minor issues with the
CallMethodRuleTestCase test :
- testSettingProperties is too long and performs several independant
tests, it should be split into different test methods.
- a new Digester is instantiated in many places, the one created in the
setUp should be used instead.
- commented code should be removed (espacially the code initializing a
SimpleLog for the Digester).
- unused objects should be removed (for example the result of
digester.parse is often affected to Object root1, but sometimes root1 is
never used).
Emmanuel Bourg