You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/03/15 08:26:10 UTC

[GitHub] [groovy] paulk-asert commented on a change in pull request #1517: GROOVY-9977: share logic for functional interface assignment

paulk-asert commented on a change in pull request #1517:
URL: https://github.com/apache/groovy/pull/1517#discussion_r594131392



##########
File path: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
##########
@@ -1834,19 +1838,22 @@ public void visitField(final FieldNode node) {
         try {
             typeCheckingContext.isInStaticContext = node.isInStaticContext();
             currentField = node;
-            super.visitField(node);
+            visitAnnotations(node);

Review comment:
       Normal visitor pattern would call super here. Perhaps a comment here to indicate that were replicating some of super.visitField to avoid processing init expression twice?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org