You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/11 07:46:43 UTC

[GitHub] [kylin] wangxiaojing123 opened a new pull request #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube

wangxiaojing123 opened a new pull request #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube
URL: https://github.com/apache/kylin/pull/1051
 
 
   - issue link : https://issues.apache.org/jira/browse/KYLIN-4334

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube
URL: https://github.com/apache/kylin/pull/1051#issuecomment-581871739
 
 
   I have tested it, it works well, let's merge it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube
URL: https://github.com/apache/kylin/pull/1051#issuecomment-573294523
 
 
   ## Pull Request Test Coverage Report for [Build 5500](https://coveralls.io/builds/28043389)
   
   * **0** of **11**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **8** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (-2.0e**-05%**) to **27.453%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/28043389/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L443) | 0 | 11 | 0.0%
   <!-- | **Total:** | **0** | **11** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28043389/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/28043389/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28043389/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L555) | 4 | 77.81% |
   <!-- | **Total:** | **8** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28043389/badge)](https://coveralls.io/builds/28043389) |
   | :-- | --: |
   | Change from base [Build 5496](https://coveralls.io/builds/27996604): |  -2.0e-05% |
   | Covered Lines: | 24071 |
   | Relevant Lines: | 87680 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube
URL: https://github.com/apache/kylin/pull/1051#issuecomment-573294295
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=h1) Report
   > Merging [#1051](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1051/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1051      +/-   ##
   ============================================
   - Coverage        25%   24.99%   -0.02%     
   + Complexity     6180     6179       -1     
   ============================================
     Files          1438     1438              
     Lines         87669    87680      +11     
     Branches      12256    12258       +2     
   ============================================
   - Hits          21926    21915      -11     
   - Misses        63593    63612      +19     
   - Partials       2150     2153       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/1051/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1051/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
   | [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1051/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0%> (-3.04%)` | `21% <0%> (-1%)` | |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1051/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1051/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=footer). Last update [3777021...bd951eb](https://codecov.io/gh/apache/kylin/pull/1051?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus merged pull request #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1051: KYLIN-4334 Auto discard all jobs while disable the Real Time Cube
URL: https://github.com/apache/kylin/pull/1051
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services