[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5586: Fix the wrong unbounded values in RangePredicateEvaluatorFactory

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5586:
URL: https://github.com/apache/incubator-pinot/pull/5586#discussion_r441944887



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateEvaluatorProvider.java
##########
@@ -77,8 +77,8 @@ public static PredicateEvaluator getPredicateEvaluator(Predicate predicate, Dict
             throw new UnsupportedOperationException("Unsupported predicate type: " + predicate.getType());
         }
       }
-    } catch (NumberFormatException e) {
-      // This NumberFormatException is caused by passing in a non-numeric string as numeric number in query
+    } catch (Exception e) {

Review comment:
       Yes, `BytesUtils.toBytes()` can throw `IllegalArgumentException`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org