You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/01/29 18:20:38 UTC
Review Request 65393: Fixed docker command health check to use the
right docker socket.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
The original command health check was calling `docker exec` instead
of `docker -H <docker_socket> exec`, so it was ignoring the socket
value passed to the docker executor.
Diffs
-----
src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65393/diff/1/
Testing
-------
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196481
-----------------------------------------------------------
Ship it!
But let's double check that socket bit for Linux. Seems just fine.
- Andrew Schwartzmeyer
On Jan. 29, 2018, 10:20 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 10:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/1/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196453
-----------------------------------------------------------
PASS: Mesos patch 65393 was successfully built and tested.
Reviews applied: `['65393']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65393
- Mesos Reviewbot Windows
On Jan. 29, 2018, 6:20 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 6:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/1/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Jan. 29, 2018, 9 p.m., Andrew Schwartzmeyer wrote:
> > src/docker/executor.cpp
> > Lines 623-624 (patched)
> > <https://reviews.apache.org/r/65393/diff/1/?file=1949979#file1949979line623>
> >
> > Any chance this could break a Linux deployment?
I don't think anything would break, but the mesosphere people probably would know better. The "-H" flag is used throughout the rest of the docker code like in `docker->run`, so now matches those functions.
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196464
-----------------------------------------------------------
On Jan. 29, 2018, 6:20 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 6:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/1/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review196464
-----------------------------------------------------------
src/docker/executor.cpp
Lines 623-624 (patched)
<https://reviews.apache.org/r/65393/#comment276119>
Any chance this could break a Linux deployment?
- Andrew Schwartzmeyer
On Jan. 29, 2018, 10:20 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 10:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/1/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review197336
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Feb. 12, 2018, 2:50 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 2:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/2/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 1:39 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
Changes
-------
Rebased.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
The original command health check was calling `docker exec` instead
of `docker -H <docker_socket> exec`, so it was ignoring the socket
value passed to the docker executor.
Diffs (updated)
-----
src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc
Diff: https://reviews.apache.org/r/65393/diff/4/
Changes: https://reviews.apache.org/r/65393/diff/3-4/
Testing
-------
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review197850
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 16, 2018, 11:25 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 11:25 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc
>
>
> Diff: https://reviews.apache.org/r/65393/diff/3/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
-----------------------------------------------------------
(Updated Feb. 16, 2018, 11:25 p.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
Changes
-------
rebased
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
The original command health check was calling `docker exec` instead
of `docker -H <docker_socket> exec`, so it was ignoring the socket
value passed to the docker executor.
Diffs (updated)
-----
src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc
Diff: https://reviews.apache.org/r/65393/diff/3/
Changes: https://reviews.apache.org/r/65393/diff/2-3/
Testing
-------
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/
-----------------------------------------------------------
(Updated Feb. 12, 2018, 10:50 p.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
Changes
-------
rebased.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
The original command health check was calling `docker exec` instead
of `docker -H <docker_socket> exec`, so it was ignoring the socket
value passed to the docker executor.
Diffs (updated)
-----
src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
Diff: https://reviews.apache.org/r/65393/diff/2/
Changes: https://reviews.apache.org/r/65393/diff/1-2/
Testing
-------
ran mesos-tests --docker flag.
Thanks,
Akash Gupta
Re: Review Request 65393: Fixed docker command health check to use
the right docker socket.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review197321
-----------------------------------------------------------
Ship it!
This shouldn't cause any problems on non-Windows (and specifying the socket is usually better than not specifying it).
- Joseph Wu
On Jan. 29, 2018, 10:20 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65393/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 10:20 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original command health check was calling `docker exec` instead
> of `docker -H <docker_socket> exec`, so it was ignoring the socket
> value passed to the docker executor.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61
> src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a
>
>
> Diff: https://reviews.apache.org/r/65393/diff/1/
>
>
> Testing
> -------
>
> ran mesos-tests --docker flag.
>
>
> Thanks,
>
> Akash Gupta
>
>