You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "d4x1 (via GitHub)" <gi...@apache.org> on 2024/01/05 03:28:49 UTC
[PR] fix(dashboard): fix circle ci [incubator-devlake]
d4x1 opened a new pull request, #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [x] I have added relevant tests.
- [x] I have added relevant documentation.
- [x] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
What does this PR do?
1. Fix wording errors in CircleCI's dashboard
2. Update filter
### Does this close any open issues?
Closes N/A
### Screenshots
Include any relevant screenshots here.
#### Filter
#### wording
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442472885
##########
grafana/dashboards/CircleCI.json:
##########
@@ -532,19 +532,19 @@
]
}
],
- "title": "1.1 Total Number of Successful Builds [Each Month]",
+ "title": "1.1 Total Number of Successful Workflows [Each Month]",
"type": "barchart"
},
{
"datasource": "mysql",
- "description": "1. Mean Build success rate over time.\n2. The builds being calculated are filtered by \"build starting time\" (time filter at the upper-right corner) and \"Jira board\" (\"Choose Board\" filter at the upper-left corner)",
+ "description": "1. Mean workflow runs success rate over time.\n2. The workflow runs being calculated are filtered by \"build starting time\" (time filter at the upper-right corner) and \"Jira board\" (\"Choose Board\" filter at the upper-left corner)",
Review Comment:
Let's use workflows, not workflow runs, to make it consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442472784
##########
grafana/dashboards/CircleCI.json:
##########
@@ -947,18 +947,18 @@
]
},
"datasource": "mysql",
- "definition": "select distinct cicd_scope_id as text from cicd_pipelines where id like \"%circleci%\" ",
+ "definition": "select concat(name, '--', id) as text from cicd_scopes where id like \"%circleci%\" ",
"description": null,
"error": null,
"hide": 0,
"includeAll": true,
- "label": "Job Name",
+ "label": "Project Name",
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442472749
##########
grafana/dashboards/CircleCI.json:
##########
@@ -358,12 +358,12 @@
],
"timeFrom": null,
"timeShift": null,
- "title": "3. Total Build Result Distribution",
+ "title": "3. Total Workflow Result Distribution",
"type": "piechart"
},
{
"datasource": "mysql",
- "description": "Number of successful builds / Number of total builds",
+ "description": "Number of successful pipelines / Number of total pipelines",
Review Comment:
Not updated yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky merged PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442475369
##########
grafana/dashboards/CircleCI.json:
##########
@@ -532,19 +532,19 @@
]
}
],
- "title": "1.1 Total Number of Successful Builds [Each Month]",
+ "title": "1.1 Total Number of Successful Workflows [Each Month]",
"type": "barchart"
},
{
"datasource": "mysql",
- "description": "1. Mean Build success rate over time.\n2. The builds being calculated are filtered by \"build starting time\" (time filter at the upper-right corner) and \"Jira board\" (\"Choose Board\" filter at the upper-left corner)",
+ "description": "1. Mean workflow runs success rate over time.\n2. The workflow runs being calculated are filtered by \"build starting time\" (time filter at the upper-right corner) and \"Jira board\" (\"Choose Board\" filter at the upper-left corner)",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442470789
##########
grafana/dashboards/CircleCI.json:
##########
@@ -947,18 +947,18 @@
]
},
"datasource": "mysql",
- "definition": "select distinct cicd_scope_id as text from cicd_pipelines where id like \"%circleci%\" ",
+ "definition": "select concat(name, '--', id) as text from cicd_scopes where id like \"%circleci%\" ",
"description": null,
"error": null,
"hide": 0,
"includeAll": true,
- "label": "Job Name",
+ "label": "Project Name",
Review Comment:
Maybe 'CircleCI Project'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dashboard): fix circle ci [incubator-devlake]
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on code in PR #6747:
URL: https://github.com/apache/incubator-devlake/pull/6747#discussion_r1442473672
##########
grafana/dashboards/CircleCI.json:
##########
@@ -358,12 +358,12 @@
],
"timeFrom": null,
"timeShift": null,
- "title": "3. Total Build Result Distribution",
+ "title": "3. Total Workflow Result Distribution",
"type": "piechart"
},
{
"datasource": "mysql",
- "description": "Number of successful builds / Number of total builds",
+ "description": "Number of successful pipelines / Number of total pipelines",
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org