You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2024/05/07 07:14:03 UTC
[PR] [ISSUE #8103] Fix SimpleSubscriptionData equal [rocketmq]
drpmma opened a new pull request, #8104:
URL: https://github.com/apache/rocketmq/pull/8104
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #8103
### Brief Description
Fix SimpleSubscriptionData equal
### How Did You Test This Change?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8103] Fix SimpleSubscriptionData equal [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8104:
URL: https://github.com/apache/rocketmq/pull/8104#issuecomment-2097651017
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8104?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `50.00000%` with `1 lines` in your changes are missing coverage. Please review.
> Project coverage is 42.86%. Comparing base [(`b39f65e`)](https://app.codecov.io/gh/apache/rocketmq/commit/b39f65ec08b9a0a72f9fdd5b826f2b1c88c9c496?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e8d2e3a`)](https://app.codecov.io/gh/apache/rocketmq/pull/8104?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 14 commits behind head on develop.
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8104?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../protocol/subscription/SimpleSubscriptionData.java](https://app.codecov.io/gh/apache/rocketmq/pull/8104?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fprotocol%2Fsubscription%2FSimpleSubscriptionData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL3N1YnNjcmlwdGlvbi9TaW1wbGVTdWJzY3JpcHRpb25EYXRhLmphdmE=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8104 +/- ##
=============================================
- Coverage 42.88% 42.86% -0.03%
- Complexity 10348 10362 +14
=============================================
Files 1270 1270
Lines 88673 88690 +17
Branches 11398 11399 +1
=============================================
- Hits 38029 38014 -15
- Misses 45950 45981 +31
- Partials 4694 4695 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8104?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8103] Fix SimpleSubscriptionData equal [rocketmq]
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #8104:
URL: https://github.com/apache/rocketmq/pull/8104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org