You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2007/01/27 23:05:12 UTC
svn commit: r500636 - in /james/server/trunk/src:
java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java
test/org/apache/james/smtpserver/SMTPServerTest.java
Author: norman
Date: Sat Jan 27 14:05:11 2007
New Revision: 500636
URL: http://svn.apache.org/viewvc?view=rev&rev=500636
Log:
Not accept recipient after unresolvable domain. See JAMES-771
Modified:
james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java
james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java
Modified: james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java?view=diff&rev=500636&r1=500635&r2=500636
==============================================================================
--- james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java (original)
+++ james/server/trunk/src/java/org/apache/james/smtpserver/core/filter/fastfail/ValidSenderDomainHandler.java Sat Jan 27 14:05:11 2007
@@ -115,6 +115,7 @@
}
if (records == null || records.size() == 0) {
+ session.getState().remove(SMTPSession.SENDER);
return true;
}
}
Modified: james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java
URL: http://svn.apache.org/viewvc/james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java?view=diff&rev=500636&r1=500635&r2=500636
==============================================================================
--- james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java (original)
+++ james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java Sat Jan 27 14:05:11 2007
@@ -490,13 +490,12 @@
smtpProtocol1.helo(InetAddress.getLocalHost().toString());
String sender1 = "mail_sender1@xfwrqqfgfe.de";
- String sender2 = "mail_sender2@james.apache.org";
smtpProtocol1.setSender(sender1);
assertEquals("expected 501 error", 501, smtpProtocol1.getReplyCode());
-
- smtpProtocol1.setSender(sender2);
-
+
+ smtpProtocol1.addRecipient("test@localhost");
+ assertEquals("Recipient not accepted cause no valid sender", 503, smtpProtocol1.getReplyCode());
smtpProtocol1.quit();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org