You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2016/10/17 23:44:56 UTC
[GitHub] incubator-hawq pull request #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if...
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/965
HAWQ-1057. Skip SARG_PUSHDOWN parameter if any of filters isn't suppo\u2026
\u2026rted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1057
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/965.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #965
----
commit 45cc696e5aaa6db297877a963ec6d4ff3650bbb3
Author: Oleksandr Diachenko <od...@pivotal.io>
Date: 2016-10-17T22:28:22Z
HAWQ-1057. Skip SARG_PUSHDOWN parameter if any of filters isn't supported.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if any of...
Posted by GodenYao <gi...@git.apache.org>.
Github user GodenYao commented on the issue:
https://github.com/apache/incubator-hawq/pull/965
+1 \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/965#discussion_r83958060
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveORCAccessor.java ---
@@ -131,15 +139,20 @@ private void buildExpression(SearchArgument.Builder builder, List<Object> filter
builder.startNot();
break;
}
- buildExpression(builder, ((LogicalFilter) f).getFilterList());
- builder.end();
+ if (buildExpression(builder, ((LogicalFilter) f).getFilterList()))
--- End diff --
good catch, will add figure brackets.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/965#discussion_r83957988
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveORCAccessor.java ---
@@ -131,15 +139,20 @@ private void buildExpression(SearchArgument.Builder builder, List<Object> filter
builder.startNot();
break;
}
- buildExpression(builder, ((LogicalFilter) f).getFilterList());
- builder.end();
+ if (buildExpression(builder, ((LogicalFilter) f).getFilterList()))
+ builder.end();
+ else
+ return false;
} else {
- buildArgument(builder, f);
+ if (!buildArgument(builder, f))
--- End diff --
We need to return false only if buildArgument(builder, f) call returned false, in case of true we want to proceed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/965#discussion_r83951577
--- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveORCAccessor.java ---
@@ -131,15 +139,20 @@ private void buildExpression(SearchArgument.Builder builder, List<Object> filter
builder.startNot();
break;
}
- buildExpression(builder, ((LogicalFilter) f).getFilterList());
- builder.end();
+ if (buildExpression(builder, ((LogicalFilter) f).getFilterList()))
+ builder.end();
+ else
+ return false;
} else {
- buildArgument(builder, f);
+ if (!buildArgument(builder, f))
--- End diff --
instead just return buildArgument(builder, f)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #965: HAWQ-1057. Skip SARG_PUSHDOWN parameter if...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/965
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---