[GitHub] spark pull request #18763: [SPARK-21306][ML] For branch-2.1, OneVsRest shoul...

[facaiy <gi...@git.apache.org>]

Github user facaiy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18763#discussion_r130200461
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
    @@ -157,6 +157,16 @@ class OneVsRestSuite extends SparkFunSuite with MLlibTestSparkContext with Defau
         assert(output.schema.fieldNames.toSet === Set("label", "features", "prediction"))
       }
     
    +  test("SPARK-21306: OneVsRest should support setWeightCol") {
    +    val dataset2 = dataset.withColumn("weight", lit(1.0))
    --- End diff --
    
    use double value, `lit(1.0)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org