You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/07/18 21:36:00 UTC

[jira] [Commented] (ARROW-5981) [C++] DictionaryBuilder initialization with Array can fail silently

    [ https://issues.apache.org/jira/browse/ARROW-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888350#comment-16888350 ] 

Wes McKinney commented on ARROW-5981:
-------------------------------------

It seems generally that errors from the hashing module are suppressed

> [C++] DictionaryBuilder<T> initialization with Array can fail silently
> ----------------------------------------------------------------------
>
>                 Key: ARROW-5981
>                 URL: https://issues.apache.org/jira/browse/ARROW-5981
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 1.0.0
>
>
> See
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array/builder_dict.cc#L267
> I think it would be better to expose {{InsertValues}} on {{DictionaryBuilder}} and initialize from a known dictionary that way



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)