[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6793: NIFI-10990 Added support for converting Record types to JSON strings …

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6793:
URL: https://github.com/apache/nifi/pull/6793#discussion_r1051434505


##########
nifi-commons/nifi-record/pom.xml:
##########
@@ -27,4 +27,11 @@
         several interfaces for interacting with Records. This module should not depend
         on any external libraries.
     </description>
+
+    <dependencies>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+        </dependency>
+    </dependencies>

Review Comment:
   As noted in the above module description, the `nifi-record` module should not have any external dependencies.



##########
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java:
##########
@@ -996,6 +999,15 @@ public static String toString(final Object value, final Supplier<DateFormat> for
             }
         }
 
+        if (value instanceof MapRecord) {
+            Map<String, Object> map = ((MapRecord)value).toMap();
+            try {
+                return MAPPER.writerWithDefaultPrettyPrinter().writeValueAsString(map);
+            } catch (Exception ex) {
+                throw new IllegalTypeConversionException("Cannot convert value " + value + " of type " + value.getClass() + " to a valid String", ex);
+            }
+        }

Review Comment:
   This approach forces the implementation into a JSON-specific strategy, which is not necessarily applicable to other record-oriented data formats.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org