You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/20 02:39:00 UTC
[jira] [Work logged] (GOBBLIN-1092) do not store explain flowConfig
requests to spec catalog
[ https://issues.apache.org/jira/browse/GOBBLIN-1092?focusedWorklogId=406726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406726 ]
ASF GitHub Bot logged work on GOBBLIN-1092:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 02:38
Start Date: 20/Mar/20 02:38
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2932: [GOBBLIN-1092] added some logs, fix checkstyle, removed some redundant code
URL: https://github.com/apache/incubator-gobblin/pull/2932#issuecomment-601366246
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=h1) Report
> Merging [#2932](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/65e2a64d2e40f46203837f4785c2426eae29a12e?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2932 +/- ##
============================================
+ Coverage 45.55% 45.56% +0.01%
- Complexity 9143 9149 +6
============================================
Files 1936 1936
Lines 73208 73215 +7
Branches 8080 8081 +1
============================================
+ Hits 33349 33360 +11
+ Misses 36766 36763 -3
+ Partials 3093 3092 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `52.04% <ø> (+1.18%)` | `15 <0> (ø)` | :arrow_down: |
| [...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==) | `13.67% <0%> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [.../gobblin/service/modules/flow/FlowEdgeContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L0Zsb3dFZGdlQ29udGV4dC5qYXZh) | `75% <0%> (-10.72%)` | `8 <1> (+1)` | |
| [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | `52.59% <100%> (+0.35%)` | `13 <1> (+1)` | :arrow_up: |
| [...n/java/org/apache/gobblin/runtime/api/JobSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYlNwZWMuamF2YQ==) | `80.13% <100%> (ø)` | `17 <0> (ø)` | :arrow_down: |
| [...ce/modules/flowgraph/pathfinder/BFSPathFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9CRlNQYXRoRmluZGVyLmphdmE=) | `80% <100%> (ø)` | `8 <0> (ø)` | :arrow_down: |
| [...ache/gobblin/runtime/spec\_catalog/FlowCatalog.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19jYXRhbG9nL0Zsb3dDYXRhbG9nLmphdmE=) | `47.32% <50%> (-0.37%)` | `16 <0> (ø)` | |
| [...dules/flowgraph/pathfinder/AbstractPathFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9BYnN0cmFjdFBhdGhGaW5kZXIuamF2YQ==) | `87.7% <75%> (ø)` | `30 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `35.65% <0%> (-2.61%)` | `13% <0%> (-1%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=footer). Last update [65e2a64...4a154f7](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 406726)
Time Spent: 20m (was: 10m)
> do not store explain flowConfig requests to spec catalog
> --------------------------------------------------------
>
> Key: GOBBLIN-1092
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1092
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)