You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/03/27 09:37:30 UTC

[jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Open for review...
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds JCLOUDS-509

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/329

-- Commit Summary --

  * Support &#39;AssociatePublicIpAddress&#39; in AWS EC2

-- File Changes --

    M core/src/main/java/org/jclouds/reflect/FunctionalReflection.java (26)
    M providers/aws-ec2/pom.xml (2)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ApiMetadata.java (15)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/binders/BindLaunchSpecificationToFormParams.java (35)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/AWSEC2TemplateOptions.java (59)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/strategy/AWSEC2CreateNodesInGroupThenAddToSet.java (39)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/strategy/CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptions.java (16)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/domain/AWSRunningInstance.java (29)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/domain/LaunchSpecification.java (68)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/options/AWSRunInstancesOptions.java (36)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/xml/LaunchSpecificationHandler.java (20)
    M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/PlacementGroupApiExpectTest.java (13)
    M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/features/SpotInstanceApiExpectTest.java (13)
    M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/functions/SpotInstanceRequestToAWSRunningInstanceTest.java (4)
    M providers/aws-ec2/src/test/resources/describe_instances_1.xml (2)
    M providers/aws-ec2/src/test/resources/describe_instances_2.xml (2)
    M providers/aws-ec2/src/test/resources/describe_instances_3.xml (2)
    M providers/aws-ec2/src/test/resources/describe_instances_latest.xml (2)
    M providers/aws-ec2/src/test/resources/describe_instances_pending.xml (2)
    M providers/aws-ec2/src/test/resources/describe_security_groups_vpc.xml (2)
    M providers/aws-ec2/src/test/resources/describe_spot_instance.xml (2)
    M providers/aws-ec2/src/test/resources/describe_spot_instance_requests.xml (2)
    M providers/aws-ec2/src/test/resources/describe_spot_instance_tags.xml (2)
    M providers/aws-ec2/src/test/resources/describe_spot_instances_1.xml (2)
    M providers/aws-ec2/src/test/resources/describe_spot_price_history.xml (2)
    M providers/aws-ec2/src/test/resources/request_spot_instances-ebs.xml (2)
    M providers/aws-ec2/src/test/resources/request_spot_instances.xml (2)
    M providers/aws-ec2/src/test/resources/run_instances_1.xml (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/329.patch
https://github.com/jclouds/jclouds/pull/329.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
> @@ -28,8 +25,10 @@
>  import org.jclouds.ec2.compute.config.EC2ResolveImagesModule;
>  import org.jclouds.rest.internal.BaseHttpApiMetadata;
>  
> -import com.google.common.collect.ImmutableSet;
> -import com.google.inject.Module;
> +import java.net.URI;
> +import java.util.Properties;
> +
> +import static org.jclouds.ec2.reference.EC2Constants.PROPERTY_EC2_AMI_OWNERS;

Again, please undo the import reformatting.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329/files#r11016379

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1178](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1178/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783375

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
Closed #329.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
Ha...so that's your GitHub ID, @lahirus ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38876538

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by lahirus <no...@github.com>.
> @@ -26,19 +39,6 @@
>  import static org.jclouds.reflect.Reflection2.typeToken;
>  import static org.jclouds.util.Throwables2.propagateIfPossible;
>  
> -import java.lang.reflect.Method;
> -import java.lang.reflect.Proxy;
> -import java.util.Arrays;
> -import java.util.Collections;
> -import java.util.List;
> -
> -import com.google.common.annotations.Beta;
> -import com.google.common.base.Function;
> -import com.google.common.base.Objects;
> -import com.google.common.collect.ImmutableList;
> -import com.google.common.reflect.Invokable;
> -import com.google.common.reflect.TypeToken;
> -

Will undo these and send a pull request.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329/files#r11035344

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
> @@ -26,19 +39,6 @@
>  import static org.jclouds.reflect.Reflection2.typeToken;
>  import static org.jclouds.util.Throwables2.propagateIfPossible;
>  
> -import java.lang.reflect.Method;
> -import java.lang.reflect.Proxy;
> -import java.util.Arrays;
> -import java.util.Collections;
> -import java.util.List;
> -
> -import com.google.common.annotations.Beta;
> -import com.google.common.base.Function;
> -import com.google.common.base.Objects;
> -import com.google.common.collect.ImmutableList;
> -import com.google.common.reflect.Invokable;
> -import com.google.common.reflect.TypeToken;
> -

These imports have just moved, from what I see. Undo this change?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329/files#r11016371

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by lahirus <no...@github.com>.
Yes :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38876661

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by lahirus <no...@github.com>.
Thanks a lot guys,
I will fix this imports movement.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38829771

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #965](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/965/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38786555

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #708](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/708/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783001

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
Haven't been able to review this properly, but one initial comment: could you take the "move import statements" changes out of this PR? That should make the PR smaller and easier to review.

Thanks, Lahiru!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38786399

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

Posted by Andrew Phillips <no...@github.com>.
Continuing this PR over at #333...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38882361