[GitHub] srowen commented on a change in pull request #23854: [SPARK-22000][SQL] Use String.valueOf to assign value to String type of field in Java Bean

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23854: [SPARK-22000][SQL] Use String.valueOf to assign value to String type of field in Java Bean
URL: https://github.com/apache/spark/pull/23854#discussion_r258954142
 
 

 ##########
 File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeserializationSuite.java
 ##########
 @@ -115,6 +124,70 @@ public void testBeanWithMapFieldsDeserialization() {
     Assert.assertEquals(records, MAP_RECORDS);
   }
 
+  private static final List<Row> ROWS_SPARK_22000 = new ArrayList<>();
 
 Review comment:
   All the static initialization could just be in a static block rather than split it up, but could this all be local to the new test method if that's the only place it's used?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org