You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by benqiu2016 <gi...@git.apache.org> on 2016/05/20 15:57:27 UTC
[GitHub] nifi-minifi-cpp pull request: MINIFI-6: Basic C++ implementation f...
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/4
MINIFI-6: Basic C++ implementation for MiNiFi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 9192675cc2fe015b75ba9cf24a47108e922a394f
Author: Bin Qiu <be...@gmail.com>
Date: 2016-05-19T16:46:04Z
MINIFI-6: Basic C++ implementation for MiNiFi
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #4: MINIFI-6: Basic C++ implementation for MiNiFi
Posted by benqiu2016 <gi...@git.apache.org>.
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/4
@apiri
It sounds good. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #4: MINIFI-6: Basic C++ implementation for MiNiFi
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/4
Hey @benqiu2016. I've had the opportunity to review this and scope out the functionality with the help of your README and it seems to be working well in communicating with the NiFi instance. To get a bit more granular, I was thinking of merging this into the ongoing MINIFI-6 branch so we can continue to iterate and evolve and maybe break things down a bit further.
Overall, the functionality has been great and working quite well. I've had success with the code on OS X and a couple distros of Linux.
Let me know your thoughts!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #4: MINIFI-6: Basic C++ implementation for MiNiFi
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/4
Hey @benqiu2016. I have rebased and merged this effort and pushed it to nifi-minifi-cpp/MINIFI-6 as part of 9e42ec5f3fdb0804b5977fb1abd8128f612fc71f. As it is not yet in master, the PR wasn't automatically closed out. Would you be able to close this out when you have the opportunity?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #4: MINIFI-6: Basic C++ implementation for MiNiFi
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/4
Reviewing and testing. Will leave comments as they arise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp pull request #4: MINIFI-6: Basic C++ implementation for MiNi...
Posted by benqiu2016 <gi...@git.apache.org>.
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp pull request: MINIFI-6: Basic C++ implementation f...
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/4#issuecomment-221049133
Tried building this with the default settings (-O0), which yields 1.3MB binary. Is the intention to provide a different build script for more constrained environments, (-Os yields 459K binary).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---