You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/03 21:29:56 UTC
[GitHub] [accumulo] AlbertWhitlock opened a new pull request, #2847: Bootstrap and DataTables version upgrade
AlbertWhitlock opened a new pull request, #2847:
URL: https://github.com/apache/accumulo/pull/2847
Bootstrap version is now 5.0.2 and DataTables version is now 1.12.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #2847:
URL: https://github.com/apache/accumulo/pull/2847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r957361817
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##########
@@ -18,73 +18,71 @@
under the License.
-->
- <div id="navbar" class="navbar navbar-inverse navbar-fixed-top">
- <div class="container-fluid">
- <!-- toggle -->
- <div class="navbar-header">
- <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#nav-items" aria-expanded="false">
- <span class="sr-only">Toggle navigation</span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a class="navbar-brand" id="headertitle" href="/">
- <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
- ${instance_name}
- </a>
- </div>
- <!-- Nav links -->
- <div class="collapse navbar-collapse" id="nav-items">
- <ul class="nav navbar-nav navbar-right">
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false"><span id="statusNotification" class="icon-dot normal"></span> Servers <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/manager"><span id="managerStatusNotification" class="icon-dot normal"></span> Manager Server </a></li>
- <li><a href="/tservers"><span id="serverStatusNotification" class="icon-dot normal"></span> Tablet Servers </a></li>
- <li><a href="/gc"><span id="gcStatusNotification" class="icon-dot normal"></span> Garbage collector </a></li>
- </ul>
- </li>
- <li><a href="/tables">Tables</a></li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- Activity <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/compactions">Active Compactions</a></li>
- <li><a href="/scans">Active Scans</a></li>
- <li><a href="/bulkImports">Bulk Imports</a></li>
- <li><a href="/ec">External Compactions</a></li>
- <li><a href="/replication">Replication</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Debug <span id="errorsNotification" class="badge"></span><span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/log">Recent Logs <span id="recentLogsNotifications" class="badge"></span></a></li>
- <li><a href="/problems">Table Problems <span id="tableProblemsNotifications" class="badge"></span></a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- REST <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/rest/xml">XML Summary</a></li>
- <li><a href="/rest/json">JSON Summary</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- <span class="glyphicon glyphicon-option-vertical"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a class="auto-refresh" style="cursor:pointer">Auto-Refresh</a></li>
- <li><a data-toggle="modal" href="#aboutModal">About</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<nav class="navbar navbar-expand-lg navbar-dark bg-dark">
+ <div class="container-fluid">
+ <a class="navbar-brand" id="headertitle" href="/">
+ <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
+ uno
Review Comment:
There could be value in also trying running this in a small cluster (could use muchos) to check that it is not relying on uno / mini-cluster specific configuration / conventions that would not be valid in a cluster / production environment. (Triggered by @DomGarguilo comment that the name might not always be uno)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1205539556
I took some screenshots on main and this branch and noticed some differences. Some changes can probably stay how they are, others we might want to correct.
**On the home page:**
main:
this branch:
The overview table should probably be returned to center. Also, there is a white bar at the top of every page for some reason on this branch that should probably be removed.
**On the manager page:**
main:
this branch:
It looks like the table titles appear below the table which should probably be moved back above the table. This might be the new default for DataTables, but it might be better if the titles are at the top of the tables.
**Dropdown menus:**
main:
this branch:
It looks like the text for the menu options is running outside of its background on this branch. Also, the button that was clicked to bring down this dropdown menu (`Servers` in this case) is not highlighted anymore.
**The info modal:**
main:
this branch:
On this branch the `X` button in the top right was removed and the close button was replaced by an `X` button. Personally I think this looks good but it might be good to make the modal a bit wider so that the Instance ID does not have to wrap to the next line.
**The navbar:**
main:
this branch:
I see two main differences that both seem like they should be returned to how they previously were, if possible. The counter next to `debug` is no longer highlighted, and the 3 dots button has been changed to a help button. Also it looks like there used to be a gradient for the navbar instead of a solid color like it is on this branch.
**Some of the bottons:**
main:
this branch:
Some of the styling for the buttons has changed. I personally like the look of the old button styling (with the white text and gradient background) better but not a big deal.
Here are some actionable points that can be checked off as they are completed or otherwise addressed:
- [ ] center the overview table on the home page
- [ ] remove the white bar at the top of the pages
- [ ] move the table titles back to the top of the tables
- [ ] make sure the text in the drop down menus on the nav bar are not off their background
- [ ] make sure the button clicked on the nav bar are highlighted while selected
- [ ] make the info modal wider so that the instance ID doesn't have to wrap
- [ ] highlight the counter next to debug on the nav bar
- [ ] change the help button on the nav bar back to the 3 dots
- [ ] consider reverting the styling for the buttons/navbar having a gradient background instead of solid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r956420818
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/tables.ftl:
##########
@@ -87,9 +87,14 @@
tableList.ajax.reload(null, false ); // user paging is not reset on reload
}
</script>
+ <div class="row">
+ <div class="col-xs-12">
+ <h3>Table Overview</h3>
+ </div>
+ </div>
<div>
- <table id="tableList" class="table table-bordered table-striped table-condensed">
- <caption><span class="table-caption">${tablesTitle}</span><br />
Review Comment:
Why were all of the field substitutions (`${}`) replaced with hardcoded values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] AlbertWhitlock commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
AlbertWhitlock commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r964045766
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##########
@@ -18,73 +18,71 @@
under the License.
-->
- <div id="navbar" class="navbar navbar-inverse navbar-fixed-top">
- <div class="container-fluid">
- <!-- toggle -->
- <div class="navbar-header">
- <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#nav-items" aria-expanded="false">
- <span class="sr-only">Toggle navigation</span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a class="navbar-brand" id="headertitle" href="/">
- <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
- ${instance_name}
- </a>
- </div>
- <!-- Nav links -->
- <div class="collapse navbar-collapse" id="nav-items">
- <ul class="nav navbar-nav navbar-right">
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false"><span id="statusNotification" class="icon-dot normal"></span> Servers <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/manager"><span id="managerStatusNotification" class="icon-dot normal"></span> Manager Server </a></li>
- <li><a href="/tservers"><span id="serverStatusNotification" class="icon-dot normal"></span> Tablet Servers </a></li>
- <li><a href="/gc"><span id="gcStatusNotification" class="icon-dot normal"></span> Garbage collector </a></li>
- </ul>
- </li>
- <li><a href="/tables">Tables</a></li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- Activity <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/compactions">Active Compactions</a></li>
- <li><a href="/scans">Active Scans</a></li>
- <li><a href="/bulkImports">Bulk Imports</a></li>
- <li><a href="/ec">External Compactions</a></li>
- <li><a href="/replication">Replication</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Debug <span id="errorsNotification" class="badge"></span><span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/log">Recent Logs <span id="recentLogsNotifications" class="badge"></span></a></li>
- <li><a href="/problems">Table Problems <span id="tableProblemsNotifications" class="badge"></span></a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- REST <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/rest/xml">XML Summary</a></li>
- <li><a href="/rest/json">JSON Summary</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- <span class="glyphicon glyphicon-option-vertical"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a class="auto-refresh" style="cursor:pointer">Auto-Refresh</a></li>
- <li><a data-toggle="modal" href="#aboutModal">About</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<nav class="navbar navbar-expand-lg navbar-dark bg-dark">
+ <div class="container-fluid">
+ <a class="navbar-brand" id="headertitle" href="/">
+ <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
+ uno
Review Comment:
Changed it back to ${instance_name}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
Manno15 commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1229518790
Recent commits have solved my issues so once @DomGarguilo's issues are resolved then this should be good to go. Good work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
Manno15 commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1221393868
I did run into an interesting bug. I had the monitor auto-refreshing but none of the drop-downs worked. The buttons themselves worked but that is about it. I think this is because I had the auto-refresh enabled on the monitor before updating to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1205339069
I'll take a look into these changes today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1248801716
@DomGarguilo Please don't forget to ensure the version-specific project is added before merging PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1224670239
I took a look at 2ce1953 and it looks like it fixed the auto-refresh feature. While testing it out though, I noticed something else. When a something is present in the debug menu, the counter stays green...
until the recent logs page is visited at which-point the counter turns to the yellow warning color as is expected whenever that counter is not zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r956417751
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/scans.ftl:
##########
@@ -19,13 +19,14 @@
-->
<div class="row">
- <div class="col-xs-12">
- <h3>${title}</h3>
- </div>
+ <div class="col-xs-12">
+ <h3>Active Scans Overview</h3>
+ </div>
Review Comment:
Looks like a few extra spaces got added here, might be best to remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r956425858
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##########
@@ -18,73 +18,71 @@
under the License.
-->
- <div id="navbar" class="navbar navbar-inverse navbar-fixed-top">
- <div class="container-fluid">
- <!-- toggle -->
- <div class="navbar-header">
- <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#nav-items" aria-expanded="false">
- <span class="sr-only">Toggle navigation</span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a class="navbar-brand" id="headertitle" href="/">
- <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
- ${instance_name}
- </a>
- </div>
- <!-- Nav links -->
- <div class="collapse navbar-collapse" id="nav-items">
- <ul class="nav navbar-nav navbar-right">
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false"><span id="statusNotification" class="icon-dot normal"></span> Servers <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/manager"><span id="managerStatusNotification" class="icon-dot normal"></span> Manager Server </a></li>
- <li><a href="/tservers"><span id="serverStatusNotification" class="icon-dot normal"></span> Tablet Servers </a></li>
- <li><a href="/gc"><span id="gcStatusNotification" class="icon-dot normal"></span> Garbage collector </a></li>
- </ul>
- </li>
- <li><a href="/tables">Tables</a></li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- Activity <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/compactions">Active Compactions</a></li>
- <li><a href="/scans">Active Scans</a></li>
- <li><a href="/bulkImports">Bulk Imports</a></li>
- <li><a href="/ec">External Compactions</a></li>
- <li><a href="/replication">Replication</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Debug <span id="errorsNotification" class="badge"></span><span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/log">Recent Logs <span id="recentLogsNotifications" class="badge"></span></a></li>
- <li><a href="/problems">Table Problems <span id="tableProblemsNotifications" class="badge"></span></a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- REST <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/rest/xml">XML Summary</a></li>
- <li><a href="/rest/json">JSON Summary</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- <span class="glyphicon glyphicon-option-vertical"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a class="auto-refresh" style="cursor:pointer">Auto-Refresh</a></li>
- <li><a data-toggle="modal" href="#aboutModal">About</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<nav class="navbar navbar-expand-lg navbar-dark bg-dark">
Review Comment:
Not sure what happened, but it looks like the formatting on this whole file got messed up somehow- should probably be returned to proper formatting.
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/scans.ftl:
##########
@@ -19,13 +19,14 @@
-->
<div class="row">
- <div class="col-xs-12">
- <h3>${title}</h3>
- </div>
+ <div class="col-xs-12">
+ <h3>Active Scans Overview</h3>
+ </div>
Review Comment:
Looks like some extra spaces got added on these lines
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##########
@@ -18,73 +18,71 @@
under the License.
-->
- <div id="navbar" class="navbar navbar-inverse navbar-fixed-top">
- <div class="container-fluid">
- <!-- toggle -->
- <div class="navbar-header">
- <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#nav-items" aria-expanded="false">
- <span class="sr-only">Toggle navigation</span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a class="navbar-brand" id="headertitle" href="/">
- <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
- ${instance_name}
- </a>
- </div>
- <!-- Nav links -->
- <div class="collapse navbar-collapse" id="nav-items">
- <ul class="nav navbar-nav navbar-right">
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false"><span id="statusNotification" class="icon-dot normal"></span> Servers <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/manager"><span id="managerStatusNotification" class="icon-dot normal"></span> Manager Server </a></li>
- <li><a href="/tservers"><span id="serverStatusNotification" class="icon-dot normal"></span> Tablet Servers </a></li>
- <li><a href="/gc"><span id="gcStatusNotification" class="icon-dot normal"></span> Garbage collector </a></li>
- </ul>
- </li>
- <li><a href="/tables">Tables</a></li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- Activity <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/compactions">Active Compactions</a></li>
- <li><a href="/scans">Active Scans</a></li>
- <li><a href="/bulkImports">Bulk Imports</a></li>
- <li><a href="/ec">External Compactions</a></li>
- <li><a href="/replication">Replication</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Debug <span id="errorsNotification" class="badge"></span><span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/log">Recent Logs <span id="recentLogsNotifications" class="badge"></span></a></li>
- <li><a href="/problems">Table Problems <span id="tableProblemsNotifications" class="badge"></span></a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- REST <span class="caret"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a href="/rest/xml">XML Summary</a></li>
- <li><a href="/rest/json">JSON Summary</a></li>
- </ul>
- </li>
- <li class="dropdown">
- <a class="dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">
- <span class="glyphicon glyphicon-option-vertical"></span>
- </a>
- <ul class="dropdown-menu">
- <li><a class="auto-refresh" style="cursor:pointer">Auto-Refresh</a></li>
- <li><a data-toggle="modal" href="#aboutModal">About</a></li>
- </ul>
- </li>
- </ul>
- </div>
- </div>
+<nav class="navbar navbar-expand-lg navbar-dark bg-dark">
+ <div class="container-fluid">
+ <a class="navbar-brand" id="headertitle" href="/">
+ <img id="accumulo-avatar" alt="accumulo" class="navbar-left pull-left" src="/resources/images/accumulo-avatar.png" />
+ uno
Review Comment:
The instance name will not always be uno. Thats why there was the `${instance_name}` that gets replaces with the instance name dynamically
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/tservers.ftl:
##########
@@ -18,39 +18,15 @@
under the License.
-->
- <div class="row">
+ <div class="row">
<div class="col-xs-12">
- <h3>${title}</h3>
+ <h3>Tablet Server Overview</h3>
</div>
- </div>
+ </div>
Review Comment:
looks like this div is out of line with the others. also the `<h3>` has one or two extra spaces added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1212485168
Looks like just about everything I had mentioned has been addressed. I updated the checklist above. I found a few more things that might need changing:
It doesn't look like the auto-refresh is working anymore
It looks like at least one of the drop down menus is cut off:
Also when opening this option, it covers part of the nav bar (and the botton is not highlighted when clicked like the others):
I wonder if there is a way to have these two display the drop down portion with the right side aligned (rather than the usual left side of the button aligned with the left side of the dropdown).
Other than those things, everything else looks good as far as I have seen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] AlbertWhitlock commented on a diff in pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
AlbertWhitlock commented on code in PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#discussion_r959890631
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/tables.ftl:
##########
@@ -87,9 +87,14 @@
tableList.ajax.reload(null, false ); // user paging is not reset on reload
}
</script>
+ <div class="row">
+ <div class="col-xs-12">
+ <h3>Table Overview</h3>
+ </div>
+ </div>
<div>
- <table id="tableList" class="table table-bordered table-striped table-condensed">
- <caption><span class="table-caption">${tablesTitle}</span><br />
Review Comment:
I put captions on each table and sometimes the 'title' of the page (that was at the top of the page) worked as well for a table caption so I added a different, hardcoded value for the page's overall title. I put the field substitution values back for the pages' titles and just changed the individual tables' captions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1222312761
> I did run into an interesting bug. I had the monitor auto-refreshing but none of the drop-downs worked. The buttons themselves worked but that is about it. I think this is because I had the auto-refresh enabled on the monitor before updating to these changes.
I was not able to get auto-refresh working. Did you have it working after updating to these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2847: Bootstrap and DataTables version upgrade
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2847:
URL: https://github.com/apache/accumulo/pull/2847#issuecomment-1213407557
357502a resolved my concerns about the drop downs (mentioned above).
Updated dropdowns screenshots:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org