You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/06/13 06:59:40 UTC
[GitHub] [flink-connector-aws] reswqa opened a new pull request, #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
reswqa opened a new pull request, #78:
URL: https://github.com/apache/flink-connector-aws/pull/78
<!--
*Thank you for contributing to Apache Flink AWS Connectors - we are happy that you want to help us improve our Flink connectors. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- The name of the pull request should correspond to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Commits should be in the form of "[FLINK-XXXX][component] Title of the pull request", where [FLINK-XXXX] should be replaced by the actual issue number.
Generally, [component] should be the connector you are working on.
For example: "[FLINK-XXXX][Connectors/Kinesis] XXXX" if you are working on the Kinesis connector or "[FLINK-XXXX][Connectors/AWS] XXXX" if you are working on components shared among all the connectors.
- Each pull request should only have one JIRA issue.
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
## Purpose of the change
*Nightly CI always failed as archunit violations.*
## Verifying this change
Manually trigger CI.
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231815332
##########
.github/workflows/nightly.yml:
##########
@@ -17,9 +17,7 @@
################################################################################
name: "flink-connector-aws: nightly build"
-on:
- schedule:
- - cron: "0 0 * * *"
+on: [push, pull_request]
Review Comment:
It is only used to show the nightly CI can paIt after this pr. You can see the message of the commit related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] snuyanzin commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231812320
##########
flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549:
##########
@@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not sati
* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\
+ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule
+org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not satisfy: only one of the following predicates match:\
+* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension or are , and of type MiniClusterTestEnvironment and annotated with @TestEnv\
+* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
Review Comment:
would be great if you link to the corresponding commit/jira which is the reason of that?
##########
flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549:
##########
@@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not sati
* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\
+ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule
+org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not satisfy: only one of the following predicates match:\
+* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension or are , and of type MiniClusterTestEnvironment and annotated with @TestEnv\
+* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
Review Comment:
would be great if you link to the corresponding commit/jira which is the reason of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#issuecomment-1596541116
Closed as Chesnay's comment in [FLINK-31804](https://issues.apache.org/jira/browse/FLINK-31804): `Connectors should just skip the architecture tests when running against later versions.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#issuecomment-1588978337
Please do not directly merge the latest commit, it is only used to show the night CI can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#issuecomment-1594137909
@hlteoh37 Would you mind also taking a look at this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231821319
##########
flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549:
##########
@@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not sati
* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\
+ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule
+org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not satisfy: only one of the following predicates match:\
+* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension or are , and of type MiniClusterTestEnvironment and annotated with @TestEnv\
+* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
Review Comment:
Good suggestion, FLINK-31804 is the main reason. Perhaps we should indeed backport it to `release-1.17` and `release-1.16`(not checking if it is necessary). But before we reach an agreement on it, the workaround solution can first allow the connector to run the nightly test normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] hlteoh37 commented on pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#issuecomment-1594270048
LGTM, remember to remove the changes to `nightly.yml` before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231826289
##########
flink-connector-aws-kinesis-firehose/archunit-violations/a6cbd99c-b115-447a-8f19-43c1094db549:
##########
@@ -2,5 +2,11 @@ org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not sati
* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension\
* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\
+ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule
+org.apache.flink.connector.firehose.sink.KinesisFirehoseSinkITCase does not satisfy: only one of the following predicates match:\
+* reside in a package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type InternalMiniClusterExtension and annotated with @RegisterExtension\
+* reside outside of package 'org.apache.flink.runtime.*' and contain any fields that are static, final, and of type MiniClusterExtension and annotated with @RegisterExtension or are , and of type MiniClusterTestEnvironment and annotated with @TestEnv\
+* reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\
Review Comment:
But as the comment in issue: Adding new text of violation in ArchUnit store does not seem like a good solution since ArchUnit updates ignored violations by deleting ones that are not encountered during build.
We generally do not run `TestCodeArchitectureTest` on the IDE, so there may not be any issues at the moment. But in the long run, we have to decide whether we need to backport `FLINK-31804`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231815332
##########
.github/workflows/nightly.yml:
##########
@@ -17,9 +17,7 @@
################################################################################
name: "flink-connector-aws: nightly build"
-on:
- schedule:
- - cron: "0 0 * * *"
+on: [push, pull_request]
Review Comment:
It is only used to show the nightly CI can pass after this pr. You can see the message of the commit related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] snuyanzin commented on a diff in pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #78:
URL: https://github.com/apache/flink-connector-aws/pull/78#discussion_r1231811552
##########
.github/workflows/nightly.yml:
##########
@@ -17,9 +17,7 @@
################################################################################
name: "flink-connector-aws: nightly build"
-on:
- schedule:
- - cron: "0 0 * * *"
+on: [push, pull_request]
Review Comment:
Is switching nightly by cron to on push, pr intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] reswqa closed pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa closed pull request #78: [hotfix][Connectors/Kinesis] Nightly CI always failed as archunit violations
URL: https://github.com/apache/flink-connector-aws/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org