[GitHub] [solr] magibney commented on a change in pull request #2: SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible

[GitBox <gi...@apache.org>]

magibney commented on a change in pull request #2:
URL: https://github.com/apache/solr/pull/2#discussion_r591555139



##########
File path: solr/core/src/java/org/apache/solr/search/join/GraphQuery.java
##########
@@ -268,13 +266,12 @@ private Automaton buildAutomaton(BytesRefHash termBytesHash) {
     
     @Override
     public Scorer scorer(LeafReaderContext context) throws IOException {
-      if (filter == null) {
+      if (resultSet == null) {
         resultSet = getDocSet();
-        filter = resultSet.getTopFilter();
       }
-      DocIdSet readerSet = filter.getDocIdSet(context,context.reader().getLiveDocs());
+      DocIdSetIterator disi = resultSet.iterator(context);

Review comment:
       there was previously an `acceptDocs` filter here for `context.reader().getLiveDocs()` -- probably superfluous?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org