You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/02 20:55:33 UTC
Review Request 21020: Set owner field correctly in getTasksStatus call
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21020/
-----------------------------------------------------------
Review request for Aurora and Mark Chu-Carroll.
Bugs: AURORA-373
https://issues.apache.org/jira/browse/AURORA-373
Repository: aurora
Description
-------
Was incorrectly setting the identity field instead of the owner field in getTasksStatus call.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 96748eb0c3723d48b1f98e8ae4244785639b5da3
Diff: https://reviews.apache.org/r/21020/diff/
Testing
-------
Tested on local laptop using ./gradlew run.
Verified logs.
Looked at client code in test_status.py to ensure we are making the backend call correctly.
Thanks,
Suman Karumuri
Re: Review Request 21020: Set owner field correctly in getTasksStatus call
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21020/#review42042
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On May 2, 2014, 2:55 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21020/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 2:55 p.m.)
>
>
> Review request for Aurora and Mark Chu-Carroll.
>
>
> Bugs: AURORA-373
> https://issues.apache.org/jira/browse/AURORA-373
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Was incorrectly setting the identity field instead of the owner field in getTasksStatus call.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 96748eb0c3723d48b1f98e8ae4244785639b5da3
>
> Diff: https://reviews.apache.org/r/21020/diff/
>
>
> Testing
> -------
>
> Tested on local laptop using ./gradlew run.
> Verified logs.
> Looked at client code in test_status.py to ensure we are making the backend call correctly.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 21020: Set owner field correctly in getTasksStatus call
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21020/#review42186
-----------------------------------------------------------
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/21020/#comment75931>
The identity field looks like a land-mine. Can you follow up to remove it?
- Bill Farner
On May 2, 2014, 6:55 p.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21020/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:55 p.m.)
>
>
> Review request for Aurora and Mark Chu-Carroll.
>
>
> Bugs: AURORA-373
> https://issues.apache.org/jira/browse/AURORA-373
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Was incorrectly setting the identity field instead of the owner field in getTasksStatus call.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 96748eb0c3723d48b1f98e8ae4244785639b5da3
>
> Diff: https://reviews.apache.org/r/21020/diff/
>
>
> Testing
> -------
>
> Tested on local laptop using ./gradlew run.
> Verified logs.
> Looked at client code in test_status.py to ensure we are making the backend call correctly.
>
>
> Thanks,
>
> Suman Karumuri
>
>