You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/05/01 21:07:56 UTC
Review Request: Allow site element creation to be asynchronous in open-views
features
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4951/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Implementors may now choose to provide the site element via an async callback so in case circumstances force them to need to do that.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js 1332778
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js 1332778
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1332778
Diff: https://reviews.apache.org/r/4951/diff
Testing
-------
All tests still pass. All original functionality is still supported.
Thanks,
Dan
Re: Review Request: Allow site element creation to be asynchronous in
open-views features
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4951/#review7468
-----------------------------------------------------------
Ship it!
Committed r1333049
- Dan
On 2012-05-01 19:07:56, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4951/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 19:07:56)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Implementors may now choose to provide the site element via an async callback so in case circumstances force them to need to do that.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1332778
>
> Diff: https://reviews.apache.org/r/4951/diff
>
>
> Testing
> -------
>
> All tests still pass. All original functionality is still supported.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Allow site element creation to be asynchronous in
open-views features
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4951/#review7465
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-05-01 19:07:56, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4951/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 19:07:56)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Implementors may now choose to provide the site element via an async callback so in case circumstances force them to need to do that.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1332778
>
> Diff: https://reviews.apache.org/r/4951/diff
>
>
> Testing
> -------
>
> All tests still pass. All original functionality is still supported.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Allow site element creation to be asynchronous in
open-views features
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4951/#review7444
-----------------------------------------------------------
Ship it!
It makes me cringe a little but I understand you are trying to not break anyone.
- Ryan
On 2012-05-01 19:07:56, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4951/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 19:07:56)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Implementors may now choose to provide the site element via an async callback so in case circumstances force them to need to do that.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js 1332778
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1332778
>
> Diff: https://reviews.apache.org/r/4951/diff
>
>
> Testing
> -------
>
> All tests still pass. All original functionality is still supported.
>
>
> Thanks,
>
> Dan
>
>