[GitHub] [incubator-nuttx] anchao commented on pull request #6562: net/tcp: remove all rexmit_seq related code

[GitBox <gi...@apache.org>]

anchao commented on PR #6562:
URL: https://github.com/apache/incubator-nuttx/pull/6562#issuecomment-1173134836

   Hi,
   
   I re-reviewed the previous commit, rexmit_seq should only work properly in nonbuffer mode or SNDFILE is enabled, right?
   NET_TCP_WRITE_BUFFERS is used in our project, It seems that this issue is caused by my previous pull request:
   
   https://github.com/apache/incubator-nuttx/pull/6451
   
   The reason for submitting this PR is because we found that the rexmit_seq is not updated every time in buffer mode.
   rexmit_seq in an invalid value being used when packet loss triggers fast retransmission
   
   In PR https://github.com/apache/incubator-nuttx/pull/6451, I adopted @a-lunev 's suggestion ( according to RFC 6298 (5.4) ). When triggering fast retransmission, only retransmit one segment that is not currently acknowledged, so rexmit_seq should not be used instead of sndseq in this scenario, because sndseq of retransmission in the packet does not need to be re-updated
   
   Since I haven't done enough verification in the nonbuffer and SNDFILE mode, so rexmit_seq should be disabled if NET_TCP_WRITE_BUFFERS is enabled as before, I will update this PR soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org