You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@polygene.apache.org by "Paul Merlin (JIRA)" <ji...@apache.org> on 2017/05/21 12:34:04 UTC

[jira] [Resolved] (POLYGENE-254) Source distribution contains Gradle wrapper files including JARs

     [ https://issues.apache.org/jira/browse/POLYGENE-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Merlin resolved POLYGENE-254.
----------------------------------
    Resolution: Fixed

All Gradle wrapper files have been removed from the source distribution.
For convenience they are not removed from the git repository.

The Polygene build now declare the Gradle version it requires in a single place: {{dependencies.gradle}}.
The {{wrapper}} task is configured to use that, and, a warning is issued if the current Gradle version is different.

The project generator build now copies the root Gradle wrapper files into its template.

The source distribution includes a separate small build with a single Wrapper task that bootstraps a wrapper at the root of the unpacked source distribution using the required Gradle version.

> Source distribution contains Gradle wrapper files including JARs
> ----------------------------------------------------------------
>
>                 Key: POLYGENE-254
>                 URL: https://issues.apache.org/jira/browse/POLYGENE-254
>             Project: Polygene
>          Issue Type: Bug
>            Reporter: Paul Merlin
>            Assignee: Paul Merlin
>             Fix For: 3.0.0
>
>
> The usual Gradle wrapper for the whole build at repository's root:
> {code}
> gradlew
> gradlew.bat
> gradle/wrapper/gradle-wrapper.jar
> gradle/wrapper/gradle-wrapper.properties
> {code}
> The project generator also includes a Gradle wrapper:
> {code}
> tools/generator-polygene/app/templates/build/gradlew.tmpl
> tools/generator-polygene/app/templates/build/gradlew-bat.tmpl
> tools/generator-polygene/app/templates/build/gradle-wrapper.jar_
> tools/generator-polygene/app/templates/build/gradle-wrapper.properties_
> {code}
> All these files should be removed from the source distribution.
> But, an easy bootstrap mechanism to bootstrap the Gradle wrapper of the required Gradle version should be provided.
> As part of this issue, the wrapper duplication should be fixed so the project generator for a given Polygene version produces builds that use the version of Gradle required to build Polygene. Users are then free to upgrade the wrapper in their project.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)