You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2015/12/29 04:55:17 UTC
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/577
Zeppelin-540: Notebook versioning control (git commit) from frontend notebook menu
### What is this PR for?
This PR improves the front-end experience to use git versioning on notebooks.
Any community feedback is welcome.
### What type of PR is it?
Improvement
### Todos
* [x] - front-end and back-end changes
* [ ] - error propagation to front-end
* [ ] - tests
### Is there a relevant Jira issue?
[ZEPPELIN-540](https://issues.apache.org/jira/browse/ZEPPELIN-540)
### How should this be tested?
1. Uncomment `GitNotebookRepo` as a storage in `/conf/zeppelin-site.xml`
2. Start Zeppelin
3. Make changes to some notebook
4. Use `git` menu to commit
5. To check whether successfully committed, do `git log` in `/notebooks` folder
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin feat/git-commit-frontend-access
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #577
----
commit 2ebe628bd19748bcd1535e9b22f0918d79d7e7d4
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-12-29T02:32:42Z
add button and git menu
commit 8069ccd678f2d37b9280b95e83982a061fceadc4
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-12-29T02:36:32Z
add frontend handler via websocket
commit a1894c26b934f92292ade851865ce89200efacff
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-12-29T02:37:33Z
backend handling of git notebook commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-167726857
@Leemoonsoo yes that makes it more flexible and makes sense, I'll address it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-182695989
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-167723271
@khalidhuseynov Thanks for the contribution. I think the approach make sense, but the implementation need to be more generalized. We must not assume that user will use git notebook repo.
How about add one more interface to [NotebookRepo](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java)?
```
public void checkpoint(String noteId, String checkPointName);
```
and let all notebookrepo implement this interface. This method can be invoked with proposed GUI.
Each different notebook storage implementation can implement checkpoint() for their own purpose. GitNotebookRepo use this method for making commit, for example.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: [WIP] Notebook vers...
Posted by maaark11 <gi...@git.apache.org>.
Github user maaark11 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-171008532
guys you have some communication channel, I enjoyed the project and want to help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: Notebook versioning...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-182602073
Thanks for addressing comment.
It's great improvement.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: [WIP] Notebook vers...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-172875748
tests were added, ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: [WIP] Notebook vers...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-173065461
@Leemoonsoo yes exactly! I was going to change git related things, but also wanted to hear community on `UI feedback`. Thanks for the feedback, will be addressed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: [WIP] Notebook vers...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-174262771
The code and screenshot has been updated. Currently the icon for version control was changed from [git](http://fortawesome.github.io/Font-Awesome/icon/git/) to [file-code](http://fortawesome.github.io/Font-Awesome/icon/file-code-o/) icon. However that's subject to change depending on the feedback. Other possible icons could be [anchor](http://fortawesome.github.io/Font-Awesome/icon/anchor/), [fork](http://fortawesome.github.io/Font-Awesome/icon/code-fork/) or any other suggested by community.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Zeppelin-540: [WIP] Notebook vers...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/577#issuecomment-171689459
@maaark11 Thanks for the interest : )
Mailing list here http://zeppelin.incubator.apache.org/community.html are official communication channel. You can subscribe and post message to the mailing list for any question, suggestion, feedback, discussion, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---