You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@guacamole.apache.org by Valeriu <vb...@usc.edu> on 2018/01/07 01:51:09 UTC

Re: Disable Automatic Reconnect

The workaround that I found to work was to add two lines of code in the
client source code, then compile and update the guacamole war file in the
tomcat directory.

Follow the steps for building the guacamole client from source code as
stated here
http://guacamole.apache.org/doc/gug/installing-guacamole.html#building-guacamole-client
but before running the "mvn package" command edit the file
guacamole/src/main/webapp/app/client/controllers/clientController.js in a
basic text editor.

In the text file, search for the line containing "// Determine whether the
reconnect countdown applies" and change the next line to be "var countdown =
null;" to disable the auto-reconnect feature.

Next, continue with the steps from the building guide from above.





--
Sent from: http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/

Re: Disable Automatic Reconnect

Posted by Nick Couchman <vn...@apache.org>.
On Thu, Jan 18, 2018 at 5:20 PM, Jonathan Hankins <
jhankins@homewood.k12.al.us> wrote:

> Nick,
>
> I've filed a bug report for this: https://issues.apache.
> org/jira/browse/GUACAMOLE-484
>
> -Jonathan Hankins
>
>
Great, thank you.  Maybe we can get this patch applied here in the
near-future.  If Frode doesn't want to put in the PR, I can do it.

-Nick

Re: Disable Automatic Reconnect

Posted by Jonathan Hankins <jh...@homewood.k12.al.us>.
Nick,

I've filed a bug report for this:
https://issues.apache.org/jira/browse/GUACAMOLE-484

-Jonathan Hankins

On Tue, Jan 16, 2018 at 4:37 PM Nick Couchman <vn...@apache.org> wrote:

> On Tue, Jan 9, 2018 at 1:32 PM, Jonathan Hankins <
> jhankins@homewood.k12.al.us> wrote:
>
>> Nick, can you link the bug report for the RDP reconnect bug in
>> 0.9.13-incubating? I originally reported an issue at
>> http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Need-guidance-with-suspected-auto-reconnect-bug-td2118.html and
>> then found that Frode Langelo
>> <http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/template/NamlServlet.jtp?macro=user_nodes&user=12>'s
>> patch at
>> http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Error-message-when-disconnecting-a-Windows-Server-2012-tp1835p2129.html fixed
>> the issue I was having.
>>
>> I am curious if this is the bug you referenced and if Frode's patch was
>> the fix incorporated into the codebase.
>>
>>
> Okay, does not look like that patch made it into the codebase anywhere.
> I'm curious if Mike or Frode have any input on why that would not have been
> included?
>
> Is there a current JIRA issue out there for this bug?  If not, can you
> file one for this and reference those discussions and that patch?  It looks
> like a pretty simple change, so long as it doesn't negatively impact
> something else, and getting this pushed into the Guacamole Server code
> should be relatively painless.
>
> -Nick
>

-- 
This e-mail is intended only for the recipient and may contain confidential 
or proprietary information. If you are not the intended recipient, the 
review, distribution, duplication or retention of this message and its 
attachments is prohibited. Please notify the sender of this error 
immediately by reply e-mail, and permanently delete this message and its 
attachments in any form in which they may have been preserved.

Re: Disable Automatic Reconnect

Posted by Nick Couchman <vn...@apache.org>.
On Tue, Jan 9, 2018 at 1:32 PM, Jonathan Hankins <
jhankins@homewood.k12.al.us> wrote:

> Nick, can you link the bug report for the RDP reconnect bug in
> 0.9.13-incubating? I originally reported an issue at
> http://apache-guacamole-general-user-mailing-list.
> 2363388.n4.nabble.com/Need-guidance-with-suspected-auto-
> reconnect-bug-td2118.html and then found that Frode Langelo
> <http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/template/NamlServlet.jtp?macro=user_nodes&user=12>'s
> patch at http://apache-guacamole-general-user-mailing-list.
> 2363388.n4.nabble.com/Error-message-when-disconnecting-a-
> Windows-Server-2012-tp1835p2129.html fixed the issue I was having.
>
> I am curious if this is the bug you referenced and if Frode's patch was
> the fix incorporated into the codebase.
>
>
Okay, does not look like that patch made it into the codebase anywhere.
I'm curious if Mike or Frode have any input on why that would not have been
included?

Is there a current JIRA issue out there for this bug?  If not, can you file
one for this and reference those discussions and that patch?  It looks like
a pretty simple change, so long as it doesn't negatively impact something
else, and getting this pushed into the Guacamole Server code should be
relatively painless.

-Nick

Re: Disable Automatic Reconnect

Posted by Jonathan Hankins <jh...@homewood.k12.al.us>.
Nick, can you link the bug report for the RDP reconnect bug in
0.9.13-incubating? I originally reported an issue at
http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Need-guidance-with-suspected-auto-reconnect-bug-td2118.html
and
then found that Frode Langelo
<http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/template/NamlServlet.jtp?macro=user_nodes&user=12>'s
patch at
http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Error-message-when-disconnecting-a-Windows-Server-2012-tp1835p2129.html
fixed
the issue I was having.

I am curious if this is the bug you referenced and if Frode's patch was the
fix incorporated into the codebase.

Thanks,

-Jonathan Hankins

On Sun, Jan 7, 2018 at 1:31 PM Nick Couchman <vn...@apache.org> wrote:

> On Sat, Jan 6, 2018 at 8:51 PM, Valeriu <vb...@usc.edu> wrote:
>
>> The workaround that I found to work was to add two lines of code in the
>> client source code, then compile and update the guacamole war file in the
>> tomcat directory.
>>
>> Follow the steps for building the guacamole client from source code as
>> stated here
>>
>> http://guacamole.apache.org/doc/gug/installing-guacamole.html#building-guacamole-client
>> but before running the "mvn package" command edit the file
>> guacamole/src/main/webapp/app/client/controllers/clientController.js in a
>> basic text editor.
>>
>> In the text file, search for the line containing "// Determine whether the
>> reconnect countdown applies" and change the next line to be "var
>> countdown =
>> null;" to disable the auto-reconnect feature.
>>
>
> I don't recommend doing this, as there are probably situations where it
> would be better if the auto-reconnect does actually happen.  Completely
> disabling this behavior, across the entire Guacamole install, for all
> connections, seems ever so slightly excessive.
>
> With regard to the original post for this issue, there are a couple of
> things worth noting:
> - If you're using release 0.9.13-incubating or older, there is a bug for
> RDP connections that does not correct take into account why the RDP session
> ended.  In certain situations this can cause an automatic reconnect when it
> would not normally happen, which may be contributing to the perception that
> this feature is not desirable.  I suggest trying either the version in the
> current git master release, or waiting until 0.9.14 comes out see if that
> makes the issue any less bothersome.
> - There is also a JIRA issue (
> https://issues.apache.org/jira/browse/GUACAMOLE-360) that deals with how
> Guacamole deals with a single user trying to start the same session from
> multiple locations.  This may be of interest, depending on the scenario
> being discussed.
>
> -Nick
>

-- 
This e-mail is intended only for the recipient and may contain confidential 
or proprietary information. If you are not the intended recipient, the 
review, distribution, duplication or retention of this message and its 
attachments is prohibited. Please notify the sender of this error 
immediately by reply e-mail, and permanently delete this message and its 
attachments in any form in which they may have been preserved.

Re: Disable Automatic Reconnect

Posted by Nick Couchman <vn...@apache.org>.
On Sat, Jan 6, 2018 at 8:51 PM, Valeriu <vb...@usc.edu> wrote:

> The workaround that I found to work was to add two lines of code in the
> client source code, then compile and update the guacamole war file in the
> tomcat directory.
>
> Follow the steps for building the guacamole client from source code as
> stated here
> http://guacamole.apache.org/doc/gug/installing-guacamole.
> html#building-guacamole-client
> but before running the "mvn package" command edit the file
> guacamole/src/main/webapp/app/client/controllers/clientController.js in a
> basic text editor.
>
> In the text file, search for the line containing "// Determine whether the
> reconnect countdown applies" and change the next line to be "var countdown
> =
> null;" to disable the auto-reconnect feature.
>

I don't recommend doing this, as there are probably situations where it
would be better if the auto-reconnect does actually happen.  Completely
disabling this behavior, across the entire Guacamole install, for all
connections, seems ever so slightly excessive.

With regard to the original post for this issue, there are a couple of
things worth noting:
- If you're using release 0.9.13-incubating or older, there is a bug for
RDP connections that does not correct take into account why the RDP session
ended.  In certain situations this can cause an automatic reconnect when it
would not normally happen, which may be contributing to the perception that
this feature is not desirable.  I suggest trying either the version in the
current git master release, or waiting until 0.9.14 comes out see if that
makes the issue any less bothersome.
- There is also a JIRA issue (
https://issues.apache.org/jira/browse/GUACAMOLE-360) that deals with how
Guacamole deals with a single user trying to start the same session from
multiple locations.  This may be of interest, depending on the scenario
being discussed.

-Nick