You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2025/04/25 20:03:26 UTC
[PR] Generic Table/Policy Store: Move feature config check to Adapter and some small refactoring [polaris]
HonahX opened a new pull request, #1465:
URL: https://github.com/apache/polaris/pull/1465
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
This PR moves the feature config check from `CatalogHandler::initializeCatalog` to `CatalogAdapter::newHandlerWrapper` for generic-table and policy, such that if the feature is not enabled we can directly throw unsupported exception instead of doing authorization first.
cc: @flyrain @eric-maynard @gh-yzou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generic Table/Policy Store: Move feature config check to Adapter and some small refactoring [polaris]
Posted by "gh-yzou (via GitHub)" <gi...@apache.org>.
gh-yzou commented on code in PR #1465:
URL: https://github.com/apache/polaris/pull/1465#discussion_r2060822421
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalogAdapter.java:
##########
@@ -63,10 +62,9 @@ public GenericTableCatalogAdapter(
private GenericTableCatalogHandler newHandlerWrapper(
SecurityContext securityContext, String catalogName) {
Review Comment:
@HonahX would you mind also help fix the catalogName call here, like what you did for policy, take a prefix, then call the parser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generic Table/Policy Store: Move feature config check to Adapter and some small refactoring [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1465:
URL: https://github.com/apache/polaris/pull/1465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generic Table/Policy Store: Move feature config check to Adapter and some small refactoring [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #1465:
URL: https://github.com/apache/polaris/pull/1465#discussion_r2060824640
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalogAdapter.java:
##########
@@ -63,10 +62,9 @@ public GenericTableCatalogAdapter(
private GenericTableCatalogHandler newHandlerWrapper(
SecurityContext securityContext, String catalogName) {
Review Comment:
Ah thanks for reminder, forgot that one. Let me add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Generic Table/Policy Store: Move feature config check to Adapter and some small refactoring [polaris]
Posted by "gh-yzou (via GitHub)" <gi...@apache.org>.
gh-yzou commented on code in PR #1465:
URL: https://github.com/apache/polaris/pull/1465#discussion_r2060822421
##########
service/common/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalogAdapter.java:
##########
@@ -63,10 +62,9 @@ public GenericTableCatalogAdapter(
private GenericTableCatalogHandler newHandlerWrapper(
SecurityContext securityContext, String catalogName) {
Review Comment:
@HonahX would you mind also help fix the catalogName call here, like what you did for policy, take a prefix, then call the parser, so that we are consistent on how are we handling things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org